feat: persist protocols sets #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kasteph
commented
Oct 18, 2024
•
kasteph
commented
- add protocols col to requests table
- persist protocols
- fix batchSize -> batchTime, was previously using batchSize val for time ticker interval
- fix hanging context, ctx.Done() channel was previously blocked in Queen.Run
kasteph
changed the base branch from
feat/protocols-col
to
fix/timer-normalize-reqs
kasteph
force-pushed
the
feat/persist-protocols
branch
from
33b069e to
28c44fb
Compare
kasteph
requested review from
guillaumemichel and
dennis-tra
and removed request for
guillaumemichel
guillaumemichel
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.