Clickhouse support #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennis-tra
commented
Nov 28, 2024
|
For the record, the comments were made in a call, so that's why they are not very elaborate |
dennis-tra
force-pushed
the
clickhouse
branch
2 times, most recently
from
56ee1b5 to
7510eb0
Compare
dennis-tra
commented
Dec 2, 2024
ant.go
Outdated
| @@ -23,7 +23,7 @@ const ( | |||
| ) | |||
|
|
|||
| type Ant struct { | |||
| port uint16 | |||
| port int | |||
There was a problem hiding this comment.
I actually preferred the uint16 but this gradually bubbled through the code when I added the CLI flag mapping which is an int.
dennis-tra
force-pushed
the
clickhouse
branch
3 times, most recently
from
10e19f2 to
4d89d95
Compare
dennis-tra
force-pushed
the
clickhouse
branch
from
ac58758 to
a2ffae0
Compare
dennis-tra
force-pushed
the
clickhouse
branch
from
a2ffae0 to
39a1a38
Compare
guillaumemichel
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.