Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing need for FSTAR_HOME #162

Merged
merged 11 commits into from
Jan 11, 2025
Merged

Removing need for FSTAR_HOME #162

merged 11 commits into from
Jan 11, 2025

Conversation

mtzguido
Copy link
Member

@mtzguido mtzguido commented Jan 8, 2025

(from commit messages:)

  • F* discovery: use FSTAR_EXE ?= fstar.exe
    Note: 3d itself also inspects this variable (it was inspecting
    FSTAR_HOME before). It may be easier to remove this behavior and add a
    flag, so the fstar used is explicit in the Makefiles.

  • Remove most uses of FSTAR_HOME
    A few remain in package.sh, but there it does in fact need a repo
    (afaict) so I kept it. There is also the warning in everest.sh, but I'm
    not sure why it's checking for FSTAR_HOME in the first place.

    Most of this is untested... it does build, but I didn't run the workflows.

Note: For this PR to work with FSTAR_EXE alone (and no fstar.exe in the PATH), krml must also respect FSTAR_EXE (FStarLang/karamel#512). Or we would need a krml option to choose an fstar bypassing the detection.

@mtzguido
Copy link
Member Author

Updated with the FSTAR_EXE ?= fstar.exe convention. We pass -fstar $(FSTAR_EXE) to krml when needed, and 3D also now has a --fstar option to override the F* used (otherwise we look in the PATH).

A run of the Github actions CI going on here https://github.com/mtzguido/everparse/actions/runs/12719269191.

@mtzguido mtzguido enabled auto-merge January 11, 2025 03:32
@mtzguido mtzguido merged commit 2a810a7 into project-everest:master Jan 11, 2025
5 of 6 checks passed
@mtzguido mtzguido deleted the dev branch January 11, 2025 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant