Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directly reference equipment ID when viewing another player's profile #92

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

sgtlaggy
Copy link
Contributor

@sgtlaggy sgtlaggy commented Dec 1, 2024

This fixes an edge-case where the .find could return a gear rack mannequin's equipment instead of the player's if their inventory isn't in the order expected.

@Lacyway Lacyway requested a review from ArchangelWTF December 2, 2024 04:03
@Lacyway
Copy link
Member

Lacyway commented Dec 2, 2024

@sgtlaggy is this tested thoroughly?

@ArchangelWTF
Copy link
Member

Waiting for: sp-tarkov/server#963

@sgtlaggy
Copy link
Contributor Author

sgtlaggy commented Dec 2, 2024

@sgtlaggy is this tested thoroughly?

Tested against multiple profiles connected and offline, all equipment appeared as expected.

@ArchangelWTF ArchangelWTF merged commit b0ab535 into project-fika:main Dec 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants