Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unnecessary workflow files + update version #3

Merged
merged 4 commits into from
Oct 1, 2024

Conversation

bugra-yilmaz
Copy link
Collaborator

@bugra-yilmaz bugra-yilmaz commented Sep 30, 2024

I recently merged a PR + issued a new release for this repository.

Then, I realized that the deploy workflow targeting pushes on master was triggered - an artifact from the public repository, and it failed. We don't really need this workflow in our fork and the corresponding failure messages - we maintain the deployment / publish of the new package on the IOS side 🙂

Also, I updated the version in setup.py - forgot to do this during release.

@bugra-yilmaz bugra-yilmaz changed the title chore: remove unnecessary workflow files chore: remove unnecessary workflow files + update version Sep 30, 2024
Copy link
Collaborator

@SeanC-Promaton SeanC-Promaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄 Sorry for missing the setup version last PR :/

@bugra-yilmaz
Copy link
Collaborator Author

LGTM 😄 Sorry for missing the setup version last PR :/

@SeanC-Promaton you weren't tagged in that PR 😄 - #2.

@bugra-yilmaz bugra-yilmaz merged commit ee9dcd3 into master Oct 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants