Rewriting graph implementation, a signal is made live while getting its value #32
+374
−813
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a full rewrite of the graph implementation with a bit less code.
I am opening this PR as a possible solution for the following issue I opened: tc39/proposal-signals#227
With this PR, reading a signal outside a reactive context makes it live for the duration of the get. So, calling get on a signal that is not live triggers the
watched
callback and then theunwatched
callback of the signal itself (and all depending signals that were not live).With this PR, it is possible to do this:
And
parsedPreferences$()
will always contain the up-to-date value.This PR also includes the tests and corresponding behavior from #15 and #16.
I have disabled 2 tests that I think are invalid.