Attempt to fix Issue #10 Installer should read proxy settings

[jacobdanner]

Please take these changes with a grain of salt. I was unable to get the installer to build locally for many many other reasons and figured it'd be best to pass along an 'example' of how this might be done.
It makes used of the ProxySettings plugin to get the proxy value for HTTP, the value on the stack is the checked and the --proxy flag is added properly.

[protz]

Thanks! The VM that I'm using to generate the installer is at work, so I'll generate and test a new build with your changes on Monday.

Have a nice week-end!

jonathan

[protz]

Hi,

The patch does not compile as-is, so I had to change quite a few details to get the thing to compile. However, I'm pretty sure your code won't work since the documentation for ProxySettings says that 1) GetConnectionProxyByProtocol takes two parameters: a connection name (ProxySettings::GetConnectionName) and 2) a protocol (e.g. "ftp"), not a URL. Also, the wiki page at http://nsis.sourceforge.net/ProxySettings says that this is for dialup connections...

Can you please try your changes on a local copy and submit a new version of the patch once you're confident it works?

Thanks,

jonathan

[protz]

Also, http://cygwin.com/cygwin-ug-net/setup-net.html#internet-setup says:

The Direct Connection method of downloading will directly download the packages, while the IE5 method will leverage your IE5 cache for performance. If your organisation uses a proxy server or auto-configuration scripts, the IE5 method also uses these settings.

I wonder if we could use the "IE5 method" by default instead of querying the proxy server in the nsis script.

[jacobdanner]

I have yet to be able to get the build to complete with/without my
changes which is definitely hindering me on this one.
I'll give this cygwin IE5 cache a look, great suggestion.
-jacobd

On Mon, Jun 11, 2012 at 1:55 AM, Jonathan Protzenko
[email protected]
wrote:

Also, http://cygwin.com/cygwin-ug-net/setup-net.html#internet-setup says:

The Direct Connection method of downloading will directly download the packages, while the IE5 method will leverage your IE5 cache for performance. If your organisation uses a proxy server or auto-configuration scripts, the IE5 method also uses these settings.

I wonder if we could use the "IE5 method" by default instead of querying the proxy server in the nsis script.

---

Reply to this email directly or view it on GitHub:
#11 (comment)

[protz]

If there's something unclear in the instructions that I gave in the
README file for the installer, I'd be happy to clarify / provide help.

On Thu 14 Jun 2012 11:50:31 PM CEST, Jacob Danner wrote:

I have yet to be able to get the build to complete with/without my
changes which is definitely hindering me on this one.
I'll give this cygwin IE5 cache a look, great suggestion.
-jacobd

On Mon, Jun 11, 2012 at 1:55 AM, Jonathan Protzenko
[email protected]
wrote:

Also, http://cygwin.com/cygwin-ug-net/setup-net.html#internet-setup says:

The Direct Connection method of downloading will directly download the packages, while the IE5 method will leverage your IE5 cache for performance. If your organisation uses a proxy server or auto-configuration scripts, the IE5 method also uses these settings.

I wonder if we could use the "IE5 method" by default instead of querying the proxy server in the nsis script.

---

Reply to this email directly or view it on GitHub:
#11 (comment)

---

Reply to this email directly or view it on GitHub:
#11 (comment)

[jacobdanner]

Hey Protz,
I've been poking at this a little bit on the side. It's been a long time since I poked at C++, but if I'm understanding this correctly, the default for cygwin's setup.exe is to use IE settings by default. I'm trying to verify, but its possible this is an issue on my machine since my proxy is actually a configuration url.
http://sources.redhat.com/cgi-bin/cvsweb.cgi/setup/ConnectionSetting.cc?rev=2.8&content-type=text/x-cvsweb-markup&cvsroot=cygwin-apps

Thanks again for this project, I'll keep poking.
-jacobd