Skip to content

Commit

Permalink
Warn when using --[no-]tests flags in install.rb
Browse files Browse the repository at this point in the history
The tests flag isn't functional anymore, as there are no tests in the test
directory to run. This commit adds a warning for users of the tests flag that
the flag is useless. It also changes the default value for the tests flag to
false and promises that we will remove the flag entirely in the future.
  • Loading branch information
haus committed Dec 19, 2012
1 parent 538c4fb commit fbd859f
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions install.rb
Original file line number Diff line number Diff line change
Expand Up @@ -179,8 +179,6 @@ def prepare_installation
end


InstallOptions.tests = true

ARGV.options do |opts|
opts.banner = "Usage: #{File.basename($0)} [options]"
opts.separator ""
Expand All @@ -190,8 +188,9 @@ def prepare_installation
opts.on('--[no-]ri', 'Prevents the creation of RI output.', 'Default off on mswin32.') do |onri|
InstallOptions.ri = onri
end
opts.on('--[no-]tests', 'Prevents the execution of unit tests.', 'Default on.') do |ontest|
opts.on('--[no-]tests', 'Prevents the execution of unit tests.', 'Default off.') do |ontest|
InstallOptions.tests = ontest
warn "The tests flag is no longer functional in Puppet and is deprecated as of Dec 19, 2012. It will be removed in a future version of Puppet."
end
opts.on('--[no-]configs', 'Prevents the installation of config files', 'Default off.') do |ontest|
InstallOptions.configs = ontest
Expand All @@ -217,13 +216,11 @@ def prepare_installation
opts.on('--quick', 'Performs a quick installation. Only the', 'installation is done.') do |quick|
InstallOptions.rdoc = false
InstallOptions.ri = false
InstallOptions.tests = false
InstallOptions.configs = true
end
opts.on('--full', 'Performs a full installation. All', 'optional installation steps are run.') do |full|
InstallOptions.rdoc = true
InstallOptions.ri = true
InstallOptions.tests = true
InstallOptions.configs = true
end
opts.separator("")
Expand Down

0 comments on commit fbd859f

Please sign in to comment.