Revert on failure #419
Merged
Revert on failure #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also doc and logging improvement. Discovered that the brVars list of defined variables is not always correct as bodies are unbranched, because the branches of a conditional are unbranched before the condition. This defeats this strategy for tracking the variables to save and restore.
Foreign llvm {test} instructions are given one extra Boolean output
argument, which determines the success of the test. Foreign other
language {test} instructions are given an extra int output argument,
which is interpreted as success iff it is different from 0 (following
C conventions). To implement this, TestBool instructions now allow
the argument to be an int, in which case it is compared to 0 to
determine the test outcome.
jimbxb
requested changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #411
Fix #412
Much code refactoring, especially in Types and Unbrancher modules, mainly to move information passed as arguments into state monads.