Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for Zope 4.0 #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Updates for Zope 4.0 #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b50b8cc
Globals is deprecated. Using App.special_dtml instead.
chansonit Jul 5, 2017
a1674e9
Update README.rst
carloshanson Jul 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ ZPsycopgDA depends on the psycopg2 module version at least 2.4. Don't use
versions 2.4.2 or 2.4.3: they are not compatible with ZPsycopgDA. Install the
latest version available.

ZPsycopgDA also depends on Products.ZSQLMethods.


Installation
------------
Expand All @@ -49,3 +51,16 @@ approximative. Please contact us if you want to improve them.
- Alternatively run ``easy_install ZPsycopgDA`` or ``pip install ZPsycopgDA``,
then symlink or copy the ``ZPsycopgDA`` directory from the installed
location to the ``Products`` directory of your Zope instance.


Detailed Installation for Zope 4.0
----------------------------------

Install Zope using virtualenv: http://zope.readthedocs.io/en/latest/INSTALL-virtualenv.html

$ cd /path/to/virtualenv
$ ./bin/pip install psycopg2
$ ./bin/pip install git+https://github.com/zopefoundation/Products.ZSQLMethods.git
$ ./bin/pip install git+https://github.com/psycopg/ZPsycopgDA.git
$ cd lib/python2.7/site-packages/Products
$ ln -s /path/to/virtualenv/lib/python2.7/site-packages/ZPsycopgDA .
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect these instructions to be useful for the current "zipped distribution"; however, we should "eggify" ZPsycopgDA as Products.ZPsycopgDA, and this would make the package installable the standard way (via pip or buildout), obsoleting the instructions.

Thus, my suggestion would be to merge this change to a new zipped branch, and go for the egg in a new eggified branch.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tobiasherp Are there obsolete instructions in the readme? About MR #7 I see that the url http://zope.readthedocs.io/en/latest/INSTALL-virtualenv.html is broken. can that MR be just closed?

2 changes: 1 addition & 1 deletion ZPsycopgDA/DA.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
import Shared.DC.ZRDB.Connection

from db import DB
from Globals import HTMLFile
from App.special_dtml import HTMLFile
from ExtensionClass import Base
from DateTime import DateTime

Expand Down