Flat rate whitelist support [SG-280] #253
Conversation
jason-c-child
changed the base branch from
main
to
tasiov/sg-1051-names-renewal
|
this |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## tasiov/sg-1051-names-renewal #253 +/- ##
================================================================
- Coverage 70.68% 70.51% -0.18%
================================================================
Files 26 30 +4
Lines 1699 1930 +231
================================================================
+ Hits 1201 1361 +160
- Misses 498 569 +71 ☔ View full report in Codecov by Sentry. |
|
I've updated this PR to revert the updating of the deprecated functions which is lighting up the linter. I'm not sure why its failing the linter for this while the base branch isn't. |
jason-c-child
changed the title
* minor updates * ignore lint * ignore lint * update schema
| let list = whitelists.iter().find(|whitelist| match whitelist { | ||
| WhitelistContract::Updatable(updatable) => updatable | ||
| .includes(&deps.querier, sender.to_string()) | ||
| .unwrap_or(false), | ||
| WhitelistContract::Flatrate(flatrate) => flatrate | ||
| .includes(&deps.querier, sender.to_string()) | ||
| .unwrap_or(false) | ||
| .unwrap_or(false), | ||
| }); |
There was a problem hiding this comment.
Remember receiving Generic error: Querier contract error: codespace: wasm, code: 9: execute wasm contract failed errors during on-chain tests in these match statements. Will need to test these on chain again.
There was a problem hiding this comment.
@MightOfOaks I've merged in the changes from the dYDx-airdrop branch. im curious if we can figure out why this is not matching correctly
jason-c-child
merged commit 8c53bdd
into
tasiov/sg-1051-names-renewal
The intent of these changes are to add a flat-rate whitelist to Names. The scope of changes include
updatable-whitelist-flatratecontract (largely a modified version of the original whitelist code)whitelistsarray inname-minter