Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update flat rate whitelist to support multiple admins #254

Merged
merged 7 commits into from
Jan 27, 2024
Merged

Update flat rate whitelist to support multiple admins #254

merged 7 commits into from
Jan 27, 2024

Conversation

MightOfOaks
Copy link
Member

No description provided.

@MightOfOaks MightOfOaks marked this pull request as ready for review January 27, 2024 12:59
jason-c-child
jason-c-child reviewed Jan 27, 2024
View reviewed changes
Copy link
Contributor

@jason-c-child jason-c-child left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there other instances where we support multiple admins in our contracts?

@MightOfOaks
Copy link
Member Author

Are there other instances where we support multiple admins in our contracts?

https://github.com/public-awesome/launchpad/tree/main/contracts/whitelists/whitelist is an example.

We mainly need it to set the dYdX airdrop contract as an admin after its instantiation while still maintaining manual access just in case.

@jason-c-child
Copy link
Contributor

Are there other instances where we support multiple admins in our contracts?

https://github.com/public-awesome/launchpad/tree/main/contracts/whitelists/whitelist is an example.

We mainly need it to set the dYdX airdrop contract as an admin after its instantiation while still maintaining manual access just in case.

Sweet, sgtm

jason-c-child
jason-c-child approved these changes Jan 27, 2024
View reviewed changes
Copy link
Contributor

@jason-c-child jason-c-child left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 😊

@MightOfOaks MightOfOaks merged commit 7a6ef56 into flat-rate-whitelist Jan 27, 2024
10 checks passed
@MightOfOaks MightOfOaks deleted the serkan/whitelist-multiple-admins branch January 27, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jason-c-child jason-c-child jason-c-child approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MightOfOaks @jason-c-child