[PR #1118/466f1ebb backport][0.30] Update base_url in test if content_origin is null #1119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
If `content_origin` is not set, the `distribution.base_url` will be defined with the relative path and the curl command in the test script will fail to run because of the missing hostname/address. ref: pulp/pulpcore#6175 (cherry picked from commit 466f1eb)
ggainey
approved these changes
Jan 20, 2025
ggainey
deleted the
patchback/backports/0.30/466f1ebbf99f42cbf4f9046c9e8fad2907cf8a8f/pr-1118
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #1118 as merged into main (466f1eb).
If
content_originis not set, thedistribution.base_urlwill be defined with the relative path and the curl command in the test script will fail to run because of the missing hostname/address.ref: pulp/pulpcore#6175