Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PULP-205] Allow multiple bind addresses on entrypoints #6063

Merged
merged 1 commit into from
Nov 25, 2024
Merged

[PULP-205] Allow multiple bind addresses on entrypoints #6063

merged 1 commit into from
Nov 25, 2024

Conversation

mdellweg
Copy link
Member

Both content and api worker allow to specify --bind multiple times now.

fixes #6053

@mdellweg mdellweg changed the title Allow multiple bind addresses on entrypoints [PULP-205] Allow multiple bind addresses on entrypoints Nov 22, 2024
@mdellweg
Allow multiple bind addresses on entrypoints
cd59f58 
Both content and api worker allow to specify --bind multiple times now.

fixes pulp#6053
@mdellweg mdellweg marked this pull request as ready for review November 22, 2024 21:02
gerrod3
gerrod3 reviewed Nov 25, 2024
View reviewed changes
pulpcore/app/entrypoint.py
@@ -136,5 +136,6 @@ def load(self):
@click.option("--user", "-u")
@click.option("--group", "-g")
@click.command()
def main(**options):
def main(bind, **options):
options["bind"] = list(bind)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is bind not automatically turned into a list with multiple=True and the default being a list?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, sadly we get a tuple and gunicorn doesn't like that.

@mdellweg mdellweg enabled auto-merge (rebase) November 25, 2024 16:38
@mdellweg mdellweg merged commit c2b648e into pulp:main Nov 25, 2024
12 checks passed
@mdellweg mdellweg deleted the 6053_multibind branch November 25, 2024 16:45
@patchback Patchback
Copy link

patchback bot commented Nov 25, 2024 •
edited
Loading

Backport to 3.49: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.49/c2b648e971594444928d4e4678db4f83696bdb17/pr-6063

Backported as #6073

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback patchback bot mentioned this pull request Nov 25, 2024
Merged
@patchback Patchback
Copy link

patchback bot commented Nov 25, 2024 •
edited
Loading

Backport to 3.63: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.63/c2b648e971594444928d4e4678db4f83696bdb17/pr-6063

Backported as #6074

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback Patchback
Copy link

patchback bot commented Nov 25, 2024 •
edited
Loading

Backport to 3.68: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.68/c2b648e971594444928d4e4678db4f83696bdb17/pr-6063

Backported as #6075

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

This was referenced Nov 25, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerrod3 gerrod3 gerrod3 approved these changes

Assignees
No one assigned
Labels
backport-3.49 backport-3.63
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PULP-205] pulpcore-api: unable to use multiple --bind command line arguments
2 participants
@mdellweg @gerrod3