Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always add core version to the api spec #6100

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Always add core version to the api spec #6100

merged 1 commit into from
Dec 2, 2024

Conversation

mdellweg
Copy link
Member

@mdellweg mdellweg commented Dec 2, 2024

This is supposed to help select proper bindings generator based on the version of pulpcore used.

@mdellweg
Always add core version to the api spec
f04c65c 
This is supposed to help select proper bindings generator based on the
version of pulpcore used.
@mdellweg mdellweg marked this pull request as ready for review December 2, 2024 17:14
pedro-psb
pedro-psb approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@pedro-psb pedro-psb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🎉

I wonder if it wont be confusing in the future to have it on the x-pulp-app-versions "even if core apis are not part of the spec.". But not sure if it's worth creating a separate field to convey the core version that it was created with.

@mdellweg
Copy link
Member Author

mdellweg commented Dec 2, 2024

I was wondering the same...

@mdellweg mdellweg merged commit f5ac084 into pulp:main Dec 2, 2024
12 checks passed
@mdellweg mdellweg deleted the add_core_to_schema branch December 2, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedro-psb pedro-psb pedro-psb approved these changes

Assignees
No one assigned
Labels
no-issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdellweg @pedro-psb