docs: add warning about version of try-puppeteer.appspot.com #7639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The URL https://try-puppeteer.appspot.com/ is mentioned around the top of `README.md` even if it is running a very outdated version (v1.4.0). I suggest either (1) remove it from the docs or (2) putting a warning that it is a bit outdated. I made a suggestion for the latter in this PR.
jschfflr
approved these changes
Oct 6, 2021
|
@theDavidBarton thanks for your contribution! Happy to get this landed as a workaround. But could you also file an issue to update the service to the latest version? Thanks! |
|
👌 sure @jschfflr. it's been created here ebidel/try-puppeteer#62. I asked @paulirish if there will be any new try-puppeteer project which will be maintained by the Puppeteer community. if there will: I'd be glad to contribute to 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Clarifies an external source in docs (README.md).
Did you add tests for your changes?
not applicable
If relevant, did you update the documentation?
not applicable
Summary
The URL https://try-puppeteer.appspot.com/ is mentioned around the top of
README.mdeven if it is running a very outdated version (v1.4.0). I suggest either (1) remove it from the docs or (2) putting a warning that it is a bit outdated.I made a suggestion for the latter in this PR.
Does this PR introduce a breaking change?
no
Other information
There has been a question about a try-puppeteer issue on SO that I partially try to address with this warning text. Some might think that it is maintained and upgraded in parallel with Puppeteer.