Improve browser and headless test documentation and examples #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsoikin
reviewed
Jul 22, 2023
.yarn/releases/yarn-4.0.0-rc.47.cjs
Outdated
There was a problem hiding this comment.
What's up with Yarn, why is it necessary?
There was a problem hiding this comment.
It probably wasn't. Removed! 👍
fsoikin
reviewed
Jul 22, 2023
test/index.html
Outdated
There was a problem hiding this comment.
Could you please move index.html, index_module.html, and index_module.js to a subdirectory? Perhaps ./test/browser
|
Hi @fsoikin thanks for the review and sorry for the huge lag. But I needed this so I thought I'd brush it up and address your comments. Hope this works! |
fsoikin
reviewed
Dec 29, 2023
fsoikin
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few improvements:
package.jsonscripts to run tests with various approaches:test:nodewith the nodemochaCLItest:browserwithparceltest:browser:modulewithparcelwith the test file as anesmmoduletest:headlessto run headless withpuppeteer(viamocha-headless-chrome)