fix docs build command on different global and venv python versions #5360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwgk
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
LGTM
Is this needed because venv does not cover the python3-config command?
... after looking for 5 minutes ...
Apparently that's still an issue.
Waiting for a day or so for feedback from @henryiii
|
I wonder if we should just bite the bullet and provide a |
Sounds good to me. |
Signed-off-by: Henry Schreiner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The build command in the docs fails when using a python venv with a different version to the global installation as python3-config will use the global one.
For example on a machine with global python 3.12 in a venv using python 3.11:
This silently causes a 'ModuleNotFound' error as the venv cannot import the generated pybind module.
Suggested changelog entry: