Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix reentrant write transient failures in tests #5447

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

msimacek
Copy link
Contributor

Disable print_destroyed in tests on GraalPy. It can trigger within and ongoing print, causing reentrancy errors. The prints have no value on GraalPy anyway, because they trigger in random places, so they cannot be tested. I also try to reenable test_iostream because that one was failing because the random prints could end up in the output capture.

Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rwgk rwgk merged commit 83b92ce into pybind:master Nov 18, 2024
81 checks passed
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Nov 18, 2024
@rwgk rwgk removed the needs changelog Possibly needs a changelog entry label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants