-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an example of training a tabular model on multiple GPUs #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weihua916
reviewed
Dec 27, 2024
@@ -122,7 +122,7 @@ def reset_parameters(self) -> None: | |||
trompt_conv.reset_parameters() | |||
self.trompt_decoder.reset_parameters() | |||
|
|||
def forward_stacked(self, tf: TensorFrame) -> Tensor: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make sure this change does not break the example code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed the change doesn't break these scripts across all supported task types:
examples/trompt.py
benchmark/data_frame_benchmark.py
benchmark/data_frame_text_benchmark.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an example for training a model on multiple GPUs.
Usage
$ python examples/trompt_multi_gpu.py
Changes
To enable it, this PR modifies
Trompt
accordingly:Some highlights in the script
examples/trompt.py
, it computes training accuracy batch-wise instead of computing it at the end of each epoch to save time (although model parameters change over steps within each epoch).all_reduce
andtorchmetrics
's API across all ranks at the end of each epoch.float(cuda_tensor)
, and by settingrepeat_interleave(..., output_size=...)
.Benchmark results from
--dataset jannis
ong6.12xlarge
with four L4 GPUs