Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the broken release links to include the v [ci skip] #407

Merged
merged 2 commits into from
May 27, 2020

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented May 26, 2020

Our tag names start with v, but the default for releases is to not use a v.

https://galgebra--407.org.readthedocs.build/en/407/changelog.html

This fixes the tags, but breaks the "next release" link...

xref bitprophet/releases#65

@eric-wieser eric-wieser modified the milestone: 0.5.0 May 26, 2020
doc/conf.py Outdated Show resolved Hide resolved
@eric-wieser eric-wieser added this to the 0.5.0 milestone May 26, 2020
@codecov
Copy link

codecov bot commented May 26, 2020

Codecov Report

Merging #407 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #407      +/-   ##
==========================================
+ Coverage   77.69%   77.71%   +0.02%     
==========================================
  Files          16       16              
  Lines        4205     4205              
==========================================
+ Hits         3267     3268       +1     
+ Misses        938      937       -1     
Impacted Files Coverage Δ
galgebra/atoms.py 97.67% <0.00%> (+1.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cb0849...b6c0272. Read the comment docs.

@utensil
Copy link
Member

utensil commented May 27, 2020

Your workaround should have fixed the Next Release link, but the rendered doc is still broken?

@utensil
Copy link
Member

utensil commented May 27, 2020

Oh,

pickling environment... failed

Traceback (most recent call last):
  File "/home/docs/checkouts/readthedocs.org/user_builds/galgebra/envs/407/src/sphinx/sphinx/cmd/build.py", line 280, in build_main
    app.build(args.force_all, filenames)
  File "/home/docs/checkouts/readthedocs.org/user_builds/galgebra/envs/407/src/sphinx/sphinx/application.py", line 348, in build
    self.builder.build_update()
  File "/home/docs/checkouts/readthedocs.org/user_builds/galgebra/envs/407/src/sphinx/sphinx/builders/__init__.py", line 299, in build_update
    len(to_build))
  File "/home/docs/checkouts/readthedocs.org/user_builds/galgebra/envs/407/src/sphinx/sphinx/builders/__init__.py", line 328, in build
    pickle.dump(self.env, f, pickle.HIGHEST_PROTOCOL)
_pickle.PicklingError: Can't pickle <class '_releases_release_uri'>: attribute lookup _releases_release_uri on builtins failed

Exception occurred:
  File "/home/docs/checkouts/readthedocs.org/user_builds/galgebra/envs/407/src/sphinx/sphinx/builders/__init__.py", line 328, in build
    pickle.dump(self.env, f, pickle.HIGHEST_PROTOCOL)
_pickle.PicklingError: Can't pickle <class '_releases_release_uri'>: attribute lookup _releases_release_uri on builtins failed
The full traceback has been saved in /tmp/sphinx-err-7m_mqaah.log, if you want to report the issue to the developers.
Please also report this if it was a user error, so that a better error message can be provided next time.
A bug report can be filed in the tracker at <https://github.com/sphinx-doc/sphinx/issues>. Thanks!

@eric-wieser
Copy link
Member Author

Will see if I can come up with a working workaround

Our tag names start with v, but the default for releases is to not use a v.
@eric-wieser eric-wieser force-pushed the eric-wiese/releases-uri branch from cc48d5b to 0c726f0 Compare May 27, 2020 09:11
@eric-wieser
Copy link
Member Author

Moving it to its own file seems to do the trick

@eric-wieser eric-wieser requested a review from utensil May 27, 2020 11:41
@@ -10,6 +10,6 @@ def __init__(self, releases_github_path):
self._path = releases_github_path

def __mod__(self, release):
if release.isdigit():
if release[0].isdigit():
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should have voiced out my doubts.

@utensil utensil merged commit ea11b1b into master May 27, 2020
@eric-wieser eric-wieser deleted the eric-wiese/releases-uri branch May 27, 2020 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants