-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the broken release links to include the v [ci skip] #407
Conversation
Codecov Report
@@ Coverage Diff @@
## master #407 +/- ##
==========================================
+ Coverage 77.69% 77.71% +0.02%
==========================================
Files 16 16
Lines 4205 4205
==========================================
+ Hits 3267 3268 +1
+ Misses 938 937 -1
Continue to review full report at Codecov.
|
Your workaround should have fixed the Next Release link, but the rendered doc is still broken? |
Oh,
|
Will see if I can come up with a working workaround |
Our tag names start with v, but the default for releases is to not use a v.
cc48d5b
to
0c726f0
Compare
Moving it to its own file seems to do the trick |
@@ -10,6 +10,6 @@ def __init__(self, releases_github_path): | |||
self._path = releases_github_path | |||
|
|||
def __mod__(self, release): | |||
if release.isdigit(): | |||
if release[0].isdigit(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should have voiced out my doubts.
Our tag names start with v, but the default for releases is to not use a v.
https://galgebra--407.org.readthedocs.build/en/407/changelog.html
This fixes the tags, but breaks the "next release" link...
xref bitprophet/releases#65