Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix API_URL and remove unused endpoints #280

Merged
merged 1 commit into from
Aug 11, 2024

Conversation

kirbyju
Copy link
Contributor

@kirbyju kirbyju commented Aug 2, 2024

I think this will fix downloads from TCIA so that you're getting the latest datasets via our newer API. Once you confirm this works properly, feel free to close #276 unless you prefer to do something more advanced at some point.

Note that both what you had previously and this change will only support accessing fully public data that doesn't require logging in. https://pypi.org/project/tcia-utils/ has functionality to take care of all the authentication stuff if you wanted to consider using that at some point, but it may be overkill if you're just trying to provide your users with easy access to sample data for testing your tool.

Copy link
Contributor

@pchlap pchlap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @kirbyju, this works nicely.

I agree that I think this is probably fine for users who want to get some sample data to get up and running with platipy. For anything more involved I would refer them to the tcia-utils library.

@pchlap pchlap merged commit 83d73e8 into pyplati:master Aug 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TCIA functionality is using a deprecated API
2 participants