Fix overlapping bus regions when alternative clustering is selected #1287
Conversation
There was a problem hiding this comment.
Many thanks for the PR :)
I have proposed two minor comments related. This is a great improvement! :)
Please add a bugfix in release_note :)
In your run, could you check if in the solved network hydro technologies are available?
An easy way is to do:
n = pypsa.Network("pypsa-earth/results/networks/...")
n.statistics()There you can see if the hydro technologies do have a positive energy dispatch?
We had reports of potential issues and the reason is the following.
While for wind/solar technology the selection of the node is not so relevant, for hydro technology it is not because they are not as distributed as solar or wind.
Note, a possible fix for the hydro issue could be available and ready to review here:
#1249
#1249 is planned for review and probably the 2 PR together can solve the alternative_clustering issues :) [review and testing is needed]
scripts/build_bus_regions.py
Outdated
| isolated_buses = n.buses[~non_isolated_buses].index | ||
| # drop isolated buses | ||
| onshore_regions = onshore_regions[~onshore_regions.name.isin(isolated_buses)] | ||
| # drop duplicates based on shape_id | ||
| onshore_regions = onshore_regions.drop_duplicates("shape_id") |
There was a problem hiding this comment.
| isolated_buses = n.buses[~non_isolated_buses].index | |
| # drop isolated buses | |
| onshore_regions = onshore_regions[~onshore_regions.name.isin(isolated_buses)] | |
| # drop duplicates based on shape_id | |
| onshore_regions = onshore_regions.drop_duplicates("shape_id") | |
| non_isolated_regions = onshore_regions[~onshore_regions.name.isin(isolated_buses)] | |
| isolated_regions = onshore_regions[onshore_regions.name.isin(isolated_buses)] | |
| # Combine regions while prioritizing non-isolated ones | |
| onshore_regions = ( | |
| pd.concat([non_isolated_regions, isolated_regions]) | |
| .drop_duplicates("shape_id", keep="first") | |
| ) |
Could you check if this works? this also allows isolated nodes to be kept if necessary. It builds on your spirit.
The logic is that non_isolated_nodes have priority over isolated ones and isolated may be kept if no other bus is available there.
Could you check if it works?
There was a problem hiding this comment.
Thank you @davide-f. I checked and this works! I think it could add some stablility.
So this code prefers non-isolated bus but isolated one could represent a region if the region got only isolated ones.
There was a problem hiding this comment.
The edited code be like
if snakemake.params.alternative_clustering:
# determine isolated buses
n.determine_network_topology()
non_isolated_buses = n.buses.duplicated(subset=["sub_network"], keep=False)
isolated_buses = n.buses[~non_isolated_buses].index
non_isolated_regions = onshore_regions[~onshore_regions.name.isin(isolated_buses)]
isolated_regions = onshore_regions[onshore_regions.name.isin(isolated_buses)]
# Combine regions while prioritizing non-isolated ones
onshore_regions = (
pd.concat([non_isolated_regions, isolated_regions])
.drop_duplicates("shape_id", keep="first")
)
if len(onshore_regions) < len(gadm_country):
logger.warning(
f"The number of remaining of buses are less than the number of administrative clusters suggested!"
)
scripts/build_bus_regions.py
Outdated
| logger.error( | ||
| f"The number of remaining of buses are less than the number of administrative clusters suggested!" | ||
| ) | ||
| raise ValueError("Insufficient buses to match administrative clusters!") |
There was a problem hiding this comment.
Do you mind making it a logger.warning instead?
I understand the reason but a hard error may have a hard impact
There was a problem hiding this comment.
Sure. I was not sure whether I need to put logger.warning or logger.error. Thanks.
As you said @davide-f, when I checked using modified I have to say #1249 and this PR should be used together. 
|
|
Hello @choiHenry :D |
choiHenry
force-pushed
the
AC_drop_overlapping_bus_regions
branch
from
5c92667 to
1eb3b34
Compare
for more information, see https://pre-commit.ci
|
@davide-f I pushed the commit! Thanks :) |
Closes # (if applicable).
Changes proposed in this Pull Request
Checklist
envs/environment.yamlanddoc/requirements.txt.config.default.yamlandconfig.tutorial.yaml.test/(note tests are changing the config.tutorial.yaml)doc/configtables/*.csvand line references are adjusted indoc/configuration.rstanddoc/tutorial.rst.doc/release_notes.rstis amended in the format of previous release notes, including reference to the requested PR.