Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(contract-manager) Small fixes #2239

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

fix(contract-manager) Small fixes #2239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contract_manager/scripts/check_proposal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ async function main() {
}

const newImplementationCode = await getCodeDigestWithoutAddress(
chain.getRpcUrl(),
chain.getWeb3(),
newImplementationAddress
);
// this should be the same keccak256 of the deployedCode property generated by truffle
Expand Down
2 changes: 1 addition & 1 deletion contract_manager/scripts/latency_entropy_with_callback.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
findEntropyContract,
findEvmChain,
} from "./common";
import Web3 from "web3";

Check warning on line 14 in contract_manager/scripts/latency_entropy_with_callback.ts

View workflow job for this annotation

GitHub Actions / test 

'Web3' is defined but never used

const parser = yargs(hideBin(process.argv))
.usage(
Expand Down Expand Up @@ -55,7 +55,7 @@
const startTime = Date.now();

const fromBlock = requestResponse.blockNumber;
const web3 = new Web3(contract.chain.getRpcUrl());
const web3 = contract.chain.getWeb3();
const entropyContract = contract.getContract();

// eslint-disable-next-line no-constant-condition
Expand Down
2 changes: 1 addition & 1 deletion contract_manager/scripts/list_entropy_contracts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ async function main() {
if (contract.getChain().isMainnet() === argv.testnet) continue;
try {
const provider = await contract.getDefaultProvider();
const w3 = new Web3(contract.getChain().getRpcUrl());
const w3 = contract.getChain().getWeb3();
const balance = await w3.eth.getBalance(provider);
const keeperBalance = await w3.eth.getBalance(keeperAddress);
let version = "unknown";
Expand Down
2 changes: 1 addition & 1 deletion contract_manager/scripts/load_test_entropy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import yargs from "yargs";
import { hideBin } from "yargs/helpers";
import {
DefaultStore,

Check warning on line 4 in contract_manager/scripts/load_test_entropy.ts

View workflow job for this annotation

GitHub Actions / test 

'DefaultStore' is defined but never used
EvmEntropyContract,
PrivateKey,
toPrivateKey,
Expand Down Expand Up @@ -76,7 +76,7 @@
const contract = findEntropyContract(chain);
const provider = await contract.getDefaultProvider();
const fee = await contract.getFee(provider);
const web3 = new Web3(contract.chain.getRpcUrl());
const web3 = contract.chain.getWeb3();
const testerContract = new web3.eth.Contract(ABI, argv.testerAddress);
const { address } = web3.eth.accounts.wallet.add(privateKey);
const transactionObject = testerContract.methods.batchRequests(
Expand Down
Loading