-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move all project configuration from setup.py
to pyproject.toml
#41
Conversation
Enabled mypy `local_partial_types` while I'm at it, makes no changes but ensures behaviour is identical to when mypy is running in daemon mode.
Having an issue with
|
Either we can drop 3.7 cause it's EOL or we can change If we drop 3.7 we can do that in two PRs: remove it from CI here then simplify code/change documentation in another. |
Removed 3.7 from CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good generally, minor feedback. Also it's a bit strange that you added all the towncrier, but I suppose it's there for explicitness/making sure we have the same conventions as trio? Then that's fine by me.
Yes, explicitness and making the same as Trio |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, only noticed two very minor things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I forgot this was a thing
In this pull request, I moved all project configuration from
setup.py
topyproject.toml
.Programming Language :: Python :: 3 :: Only
classifierlocal_partial_types
while I'm at it, makes no changes but ensures behaviour is identical to when mypy is running in daemon mode.Changed continuous integration script to be similar to Trio, adding groups and switching to pyproject based install instead of
setup.py
script