Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-129173: Use _PyUnicodeError_GetParams in PyCodec_IgnoreErrors #129174

Merged

Conversation

picnixz
Copy link
Member

@picnixz picnixz commented Jan 22, 2025

Currently a draft as it depends on completion of #126004.

This also cleans up the strict handler which has no issue per se but I'd like to make it consistent with other handlers.

@picnixz picnixz marked this pull request as ready for review January 23, 2025 15:07
@picnixz picnixz requested a review from vstinner January 23, 2025 15:41
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Python/codecs.c Outdated Show resolved Hide resolved
Co-authored-by: Victor Stinner <[email protected]>
@picnixz picnixz merged commit 36bb229 into python:main Jan 24, 2025
40 checks passed
@picnixz picnixz deleted the feat/codecs/simple-handlers-refactorization-129173 branch January 24, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants