-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add explanations of the yield statement to common_issues.rst Fixes #17996 #18422
Open
keainye
wants to merge
1
commit into
python:master
Choose a base branch
from
keainye:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+46
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -846,3 +846,49 @@ or of potential subclasses. | |
# In the context of the subclass Bar, the Self return type promises | ||
# that the return value will be Bar | ||
reveal_type(Bar.constructor()) # note: Revealed type is "Bar" | ||
|
||
Missing ``yield`` statement in generator functions | ||
-------------------------------------------------- | ||
|
||
Python uses the ``yield`` statement to determine whether a function is a | ||
generator function (https://peps.python.org/pep-0255/#specification-yield). | ||
|
||
.. code-block:: python | ||
|
||
from collections.abc import Generator, AsyncGenerator | ||
|
||
async def async_gen() -> AsyncGenerator[int]: | ||
yield 1 | ||
|
||
def gen() -> Generator[int]: | ||
yield 1 | ||
|
||
async def async_func() -> int: | ||
return 1 | ||
|
||
def func() -> int: | ||
return 1 | ||
|
||
reveal_type(async_gen()) # AsyncGenerator[int, None] | ||
reveal_type(gen()) # Generator[int, None, None] | ||
reveal_type(async_func()) # Coroutine[Any, Any, int] | ||
reveal_type(func()) # int | ||
|
||
Functions containing ``yield`` statements will be regarded as Generator functions | ||
by Python, and their return types are different from other functions. | ||
Therefore, when using ``mypy`` to check types, we need to declare the return types | ||
of such functions as Generator (or AsyncGenerator when the function is async). | ||
|
||
A common mistake is that we declared the return type of a function as | ||
Generator (AsyncGenerator) but did not use the ``yield`` statement in the function. | ||
``mypy`` will consider that the return type (no return, or normal types) of this function | ||
does not meet the expectation (generator type). | ||
|
||
.. code-block:: python | ||
|
||
from collections.abc import Generator | ||
|
||
def gen() -> Generator[int]: | ||
... # error: Missing return statement | ||
|
||
This kind of mistake is common in unfinished functions (the function body is ``...``). | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. OK, I'll add. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And this is wrong: "Missing return statement" is not specific to
Generator
, that's just because the return type is non-None and the body s trivial.A reasonable function can return a
Generator
orIterator
and contain noyield
(this passes):On the other hand, missing return statement causes a diagnostic without Generator too (except for stub files):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds reasonable, I'll re-write these lines.