Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for int32_t indices in TBE training (2H/N) #3539

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add support for int32_t indices in TBE training (2H/N) #3539

wants to merge 4 commits into from

Conversation

q10
Copy link
Contributor

@q10 q10 commented Jan 3, 2025

Summary: - Update benchmark test for int32_t Indicies

Differential Revision: D67784746

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67784746

@netlify Netlify
Copy link

netlify bot commented Jan 3, 2025 •
edited
Loading

✅ Deploy Preview for pytorch-fbgemm-docs ready!

Name Link
🔨 Latest commit b896f5e
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-fbgemm-docs/deploys/678994e8c1ceae0008a69011
😎 Deploy Preview https://deploy-preview-3539--pytorch-fbgemm-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@q10 q10 force-pushed the export-D67784746 branch from 6370fa0 to 1fab876 Compare January 6, 2025 21:43
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67784746

@q10 q10 force-pushed the export-D67784746 branch from 1fab876 to 79b2d11 Compare January 6, 2025 21:43
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67784746

@q10 q10 force-pushed the export-D67784746 branch from 79b2d11 to baaca3b Compare January 7, 2025 23:35
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 7, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2H/N) (pytorch#3539)
baaca3b 
Summary:

X-link: facebookresearch/FBGEMM#626

- Update benchmark test for `int32_t` Indicies

Reviewed By: sryap

Differential Revision: D67784746
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67784746

@q10 q10 force-pushed the export-D67784746 branch from baaca3b to 0a71dc8 Compare January 9, 2025 00:43
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 9, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2H/N) (pytorch#3539)
0a71dc8 
Summary:

X-link: facebookresearch/FBGEMM#626

- Update benchmark test for `int32_t` Indicies

Reviewed By: sryap

Differential Revision: D67784746
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67784746

@q10 q10 force-pushed the export-D67784746 branch from 0a71dc8 to b2e29a7 Compare January 9, 2025 22:23
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 9, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2H/N) (pytorch#3539)
b2e29a7 
Summary:

X-link: facebookresearch/FBGEMM#626

- Update benchmark test for `int32_t` Indicies

Reviewed By: sryap

Differential Revision: D67784746
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67784746

@q10 q10 force-pushed the export-D67784746 branch from b2e29a7 to 154a4cc Compare January 10, 2025 22:35
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 10, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2H/N) (pytorch#3539)
154a4cc 
Summary:

X-link: facebookresearch/FBGEMM#626

- Update benchmark test for `int32_t` Indicies

Reviewed By: sryap

Differential Revision: D67784746
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67784746

@q10 q10 force-pushed the export-D67784746 branch from 154a4cc to 86e7a3e Compare January 11, 2025 01:47
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 11, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2H/N) (pytorch#3539)
86e7a3e 
Summary:

X-link: facebookresearch/FBGEMM#626

- Update benchmark test for `int32_t` Indicies

Reviewed By: sryap

Differential Revision: D67784746
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67784746

@q10 q10 force-pushed the export-D67784746 branch from 86e7a3e to 7bcb927 Compare January 11, 2025 01:50
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 11, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2H/N) (pytorch#3539)
7bcb927 
Summary:

X-link: facebookresearch/FBGEMM#626

- Update benchmark test for `int32_t` Indicies

Reviewed By: sryap

Differential Revision: D67784746
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67784746

@q10 q10 force-pushed the export-D67784746 branch from 7bcb927 to 162e1f1 Compare January 11, 2025 08:04
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 11, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2H/N) (pytorch#3539)
162e1f1 
Summary:

X-link: facebookresearch/FBGEMM#626

- Update benchmark test for `int32_t` Indicies

Reviewed By: sryap

Differential Revision: D67784746
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67784746

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67784746

@q10 q10 force-pushed the export-D67784746 branch from 17c51ba to 847e0f0 Compare January 14, 2025 19:24
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 14, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2H/N) (pytorch#3539)
847e0f0 
Summary:

X-link: facebookresearch/FBGEMM#626

- Update benchmark test for `int32_t` Indicies

Reviewed By: sryap

Differential Revision: D67784746
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67784746

@q10 q10 force-pushed the export-D67784746 branch from 847e0f0 to 67cea11 Compare January 14, 2025 21:37
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 14, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2H/N) (pytorch#3539)
67cea11 
Summary:

X-link: facebookresearch/FBGEMM#626

- Update benchmark test for `int32_t` Indicies

Reviewed By: sryap

Differential Revision: D67784746
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67784746

@q10 q10 force-pushed the export-D67784746 branch from 67cea11 to bfb3a8e Compare January 14, 2025 22:44
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 14, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2H/N) (pytorch#3539)
bfb3a8e 
Summary:

X-link: facebookresearch/FBGEMM#626

- Update benchmark test for `int32_t` Indicies

Reviewed By: sryap

Differential Revision: D67784746
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67784746

@q10 q10 force-pushed the export-D67784746 branch from bfb3a8e to 934a5d1 Compare January 15, 2025 19:14
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 15, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2H/N) (pytorch#3539)
934a5d1 
Summary:

X-link: facebookresearch/FBGEMM#626

- Update benchmark test for `int32_t` Indicies

Reviewed By: sryap

Differential Revision: D67784746
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67784746

@q10 q10 force-pushed the export-D67784746 branch from 934a5d1 to e3b98e7 Compare January 15, 2025 22:56
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 15, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2H/N) (pytorch#3539)
e3b98e7 
Summary:

X-link: facebookresearch/FBGEMM#626

- Update benchmark test for `int32_t` Indicies

Reviewed By: sryap

Differential Revision: D67784746
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67784746

@q10 q10 force-pushed the export-D67784746 branch from e3b98e7 to 2c37eac Compare January 16, 2025 06:01
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 16, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2H/N) (pytorch#3539)
2c37eac 
Summary:

X-link: facebookresearch/FBGEMM#626

- Update benchmark test for `int32_t` Indicies

Reviewed By: sryap

Differential Revision: D67784746
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67784746

q10 added a commit to q10/FBGEMM that referenced this pull request Jan 16, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2H/N) (pytorch#3539)
a647424 
Summary:

X-link: facebookresearch/FBGEMM#626

- Update benchmark test for `int32_t` Indicies

Reviewed By: sryap

Differential Revision: D67784746
@q10 q10 force-pushed the export-D67784746 branch from 2c37eac to a647424 Compare January 16, 2025 06:06
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67784746

q10 added 4 commits January 16, 2025 15:22
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2F/N) (pytorch#3376)
c2a8dc8 
Summary:
X-link: facebookresearch/FBGEMM#623


X-link: facebookresearch/FBGEMM#467

- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65938455
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2I/N) (pytorch#3556)
1ada457 
Summary:
X-link: facebookresearch/FBGEMM#642


- Add `int21_t` support to `::internal::csr2csc`, for eventual `int32_t` indices support in TBE CPU

Reviewed By: basilwong, jianyuh

Differential Revision: D67920539
@q10 @facebook-github-bot
Updates and fixes to tensor_accessor.h (pytorch#3571)
9d269cb 
Summary:

X-link: facebookresearch/FBGEMM#656

- Fix `TensorAccessorBase` constructor to work with empty tensors, which are used in FBGEMM code

- Add better logging for errors

Differential Revision: D68048640
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2H/N) (pytorch#3539)
b896f5e 
Summary:

X-link: facebookresearch/FBGEMM#626

- Update benchmark test for `int32_t` Indicies

Reviewed By: sryap

Differential Revision: D67784746
@q10 q10 force-pushed the export-D67784746 branch from a647424 to b896f5e Compare January 16, 2025 23:23
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67784746

q10 added a commit to q10/FBGEMM that referenced this pull request Jan 16, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2H/N) (pytorch#3539)
7bd2d46 
Summary:

X-link: facebookresearch/FBGEMM#626

- Add `int32_t` indices support for the TBE CPU kernels

Reviewed By: sryap

Differential Revision: D67784746
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 16, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2H/N) (pytorch#3539)
3449377 
Summary:

X-link: facebookresearch/FBGEMM#626

- Add `int32_t` indices support for the TBE CPU kernels

Reviewed By: sryap

Differential Revision: D67784746
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla signed fb-exported module: rocm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@q10 @facebook-github-bot