Fix specailization issue in keyed_jagged_index_select_dim1_forward_cuda #3578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D67491452 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…da (pytorch#3578) Summary: X-link: facebookresearch/FBGEMM#664 `lengths` is a tensor with symbolic shapes. Calling `len` on it will force specialization on it which will cause data dependent failure as shown below: {F1974383976} tlparse: https://fburl.com/74rjmr8e The fix is to replace `len` with equivalent operations which support symbolic shapes. Differential Revision: D67491452
Microve
force-pushed
the
export-D67491452
branch
from
8bf822d to
66911dc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67491452 |
|
This pull request has been merged in 21d1260. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
lengthsis a tensor with symbolic shapes. Callinglenon it will force specialization on it which will cause data dependent failure as shown below:{F1974383976}
tlparse: https://fburl.com/74rjmr8e
The fix is to replace
lenwith equivalent operations which support symbolic shapes.Differential Revision: D67491452