Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for int32_t indices in TBE training (2K/N) #3583

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

q10
Copy link
Contributor

@q10 q10 commented Jan 16, 2025

Summary: - Update TBE benchmark test to support int32_t indicies

Differential Revision: D68296454

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68296454

Copy link

netlify bot commented Jan 16, 2025

Deploy Preview for pytorch-fbgemm-docs ready!

Name Link
🔨 Latest commit 8442ccf
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-fbgemm-docs/deploys/678995c53843aa0008697192
😎 Deploy Preview https://deploy-preview-3583--pytorch-fbgemm-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

q10 added 5 commits January 16, 2025 15:26
Summary:
X-link: facebookresearch/FBGEMM#623


X-link: facebookresearch/FBGEMM#467

- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65938455
Summary:
X-link: facebookresearch/FBGEMM#642


- Add `int21_t` support to `::internal::csr2csc`, for eventual `int32_t` indices support in TBE CPU

Reviewed By: basilwong, jianyuh

Differential Revision: D67920539
Summary:

X-link: facebookresearch/FBGEMM#656

- Fix `TensorAccessorBase` constructor to work with empty tensors, which are used in FBGEMM code

- Add better logging for errors

Differential Revision: D68048640
Summary:

X-link: facebookresearch/FBGEMM#626

- Add `int32_t` indices support for the TBE CPU kernels

Reviewed By: sryap

Differential Revision: D67784746
Summary:

- Update TBE benchmark test to support `int32_t` indicies

Differential Revision: D68296454
@q10 q10 force-pushed the export-D68296454 branch from 6ed9114 to 8442ccf Compare January 16, 2025 23:26
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68296454

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants