Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Torch TRT ngc container changes #3299

Merged
merged 4 commits into from
Dec 13, 2024
Merged

Torch TRT ngc container changes #3299

merged 4 commits into from
Dec 13, 2024

Conversation

apbose
Copy link
Collaborator

@apbose apbose commented Nov 19, 2024

No description provided.

@github-actions github-actions bot added component: tests Issues re: Tests component: core Issues re: The core compiler labels Nov 19, 2024
@github-actions github-actions bot requested a review from bowang007 November 19, 2024 19:23
@apbose apbose changed the title Torch trt dlfw changes Torch TRT ngc container changes Nov 19, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes that do not conform to C++ style guidelines:

diff --git a/home/runner/work/TensorRT/TensorRT/core/util/Exception.cpp b/tmp/changes.txt
index 3609b9a..afb3e9c 100644
--- a/home/runner/work/TensorRT/TensorRT/core/util/Exception.cpp
+++ b/tmp/changes.txt
@@ -1,11 +1,11 @@
#if defined(__GNUC__) && !defined(__clang__)
-  #if __GNUC__ >= 13
-    #include <cstdint>
-  #endif
+#if __GNUC__ >= 13
+#include <cstdint>
+#endif
#elif defined(__clang__)
-  #if __clang_major__ >= 13
-    #include <cstdint>
-  #endif
+#if __clang_major__ >= 13
+#include <cstdint>
+#endif
#endif

#include "core/util/Exception.h"
ERROR: Some files do not conform to style guidelines

@apbose apbose marked this pull request as draft November 19, 2024 19:23
@apbose apbose force-pushed the torchTRT_DLFW_changes branch from 6e54b31 to 83cfc67 Compare November 19, 2024 19:30
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apbose apbose marked this pull request as ready for review December 13, 2024 19:24
@apbose apbose merged commit 3982401 into main Dec 13, 2024
57 of 60 checks passed
apbose added a commit that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed component: core Issues re: The core compiler component: tests Issues re: Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants