Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: attribute error caused by trt.BuilderFlag.STRICT_TYPES #3300

Closed
wants to merge 1 commit into from

Conversation

jiwoong-choi
Copy link
Contributor

Description

When strict_type_constraints is True, accessing trt.BuilderFlag.STRICT_TYPES causes AttributeError: type object 'tensorrt.tensorrt.BuilderFlag' has no attribute 'STRICT_TYPES'. Indeed, there is no such builder flag in TensorRT, and it should be replaced by trt.BuilderFlag.OBEY_PRECISION_CONSTRAINTS.

Type of change

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
When `strict_type_constraints` is `True`, accessing `trt.BuilderFlag.STRICT_TYPES` causes `AttributeError: type object 'tensorrt.tensorrt.BuilderFlag' has no attribute 'STRICT_TYPES'`.
Indeed, there is no such builder flag in TensorRT, and should be replaced by `trt.BuilderFlag.OBEY_PRECISION_CONSTRAINTS`.
@github-actions github-actions bot added component: conversion Issues re: Conversion stage component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Nov 20, 2024
@github-actions github-actions bot requested a review from peri044 November 20, 2024 05:50
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should remove this if block because we don't expose strict_type_constraints flag to the user. We advocate for strong typing and here is the usage for it https://pytorch.org/TensorRT/user_guide/mixed_precision.html

@peri044
Copy link
Collaborator

peri044 commented Dec 12, 2024

Closing this PR. Please re-open incase you think this feature is necessary.

@peri044 peri044 closed this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants