fix: Record cudagraphs when weight streaming budget has changed #3309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: core
narendasan
reviewed
Dec 2, 2024
core/runtime/execute_engine.cpp
Outdated
| @@ -115,11 +115,15 @@ std::vector<at::Tensor> execute_engine(std::vector<at::Tensor> inputs, c10::intr | |||
| } | |||
|
|
|||
| // Whether cudagraphs needs to record the graph on this pass | |||
| bool need_cudagraphs_record = (CUDAGRAPHS_MODE && (!_cudagraphs_validate_shapes(inputs, compiled_engine))); | |||
| bool need_cudagraphs_record = | |||
There was a problem hiding this comment.
Seems like we need something a bit more comprehensive than a bunch of booleans for cudagraph rerecord
There was a problem hiding this comment.
I agree with it. I'm thinking of below structure. Could you review [PR3276]?(#3276)
https://github.com/pytorch/TensorRT/pull/3276/files#diff-3d6304b0f21f64bdf7867ceac346866d505619401e9c7b6a696cfe3bb567254eR37-R63
keehyuna
force-pushed
the
ws_cudagraph
branch
from
7bb66da to
2050887
Compare
github-actions
bot
added
documentation
|
Will adopt proper structure for runtime states after #3276 is reviewed. |
7 tasks
keehyuna
force-pushed
the
ws_cudagraph
branch
from
2050887 to
7a2d58e
Compare
github-actions
bot
removed
the
documentation
peri044
reviewed
Dec 18, 2024
| def test_weight_streaming_cudagraphs(self, _, use_python_runtime): | ||
| model = SampleModel().eval().cuda() | ||
| input = [torch.randn(*INPUT_SIZE, dtype=torch.float32).cuda()] | ||
| fx_graph = torch.fx.symbolic_trace(model) |
There was a problem hiding this comment.
can you use torch.export.export() to export the model?
| name="x", | ||
| ) | ||
| model = SampleModel().eval().cuda() | ||
| fx_graph = torch.fx.symbolic_trace(model) |
There was a problem hiding this comment.
same here. Use torch.export.export()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add flag indicates to reevaluate the runtime settings when weight streaming budget is changed.
Fixes #3308
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: