-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --profile-details
and --export-perfdoctor
option
#2565
Open
xuzhao9
wants to merge
1
commit into
pytorch:main
Choose a base branch
from
xuzhao9:export-D68134547
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+32
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuzhao9
had a problem deploying
to
docker-s3-upload
January 14, 2025 04:40 — with
GitHub Actions
Failure
xuzhao9
temporarily deployed
to
docker-s3-upload
January 14, 2025 04:40 — with
GitHub Actions
Inactive
This pull request was exported from Phabricator. Differential Revision: D68134547 |
xuzhao9
force-pushed
the
export-D68134547
branch
from
January 15, 2025 20:42
ef977ad
to
4f20a1a
Compare
xuzhao9
had a problem deploying
to
docker-s3-upload
January 15, 2025 20:42 — with
GitHub Actions
Error
xuzhao9
had a problem deploying
to
docker-s3-upload
January 15, 2025 20:42 — with
GitHub Actions
Failure
This pull request was exported from Phabricator. Differential Revision: D68134547 |
xuzhao9
added a commit
to xuzhao9/pytorch
that referenced
this pull request
Jan 15, 2025
…torch#144751) Summary: X-link: pytorch/benchmark#2565 Add `--profile-details` option to add shapes and other details to the Kineto profile. Add `--export-perfdoctor` to directly dump trace to perfdoctor for webview. Test Plan: ``` $ buck2 run mode/opt //caffe2/benchmarks/dynamo:torchbench_internal -- --only mrs_video_watch_over --performance --training --amp --export-profiler-trace --backend=inductor --profile-details --export-perfdoctor ``` https://interncache-all.fbcdn.net/manifold/perfetto-artifacts/tree/ui/index.html#!/?url=https://interncache-all.fbcdn.net/manifold/pyper_traces/tree/traces/test/inductor_mrs_video_watch_over_rank_0_20250113_173817_6535183793.json.gz Differential Revision: D68134547
xuzhao9
added a commit
to xuzhao9/benchmark
that referenced
this pull request
Jan 15, 2025
Summary: X-link: pytorch/pytorch#144751 Add `--profile-details` option to add shapes and other details to the Kineto profile. Add `--export-perfdoctor` to directly dump trace to perfdoctor for webview. Differential Revision: D68134547
xuzhao9
force-pushed
the
export-D68134547
branch
from
January 15, 2025 21:49
4f20a1a
to
61586de
Compare
This pull request was exported from Phabricator. Differential Revision: D68134547 |
xuzhao9
temporarily deployed
to
docker-s3-upload
January 15, 2025 21:49 — with
GitHub Actions
Inactive
xuzhao9
had a problem deploying
to
docker-s3-upload
January 15, 2025 21:49 — with
GitHub Actions
Failure
xuzhao9
added a commit
to xuzhao9/pytorch
that referenced
this pull request
Jan 15, 2025
…torch#144751) Summary: X-link: pytorch/benchmark#2565 Add `--profile-details` option to add shapes and other details to the Kineto profile. Add `--export-perfdoctor` to directly dump trace to perfdoctor for webview. Test Plan: ``` $ buck2 run mode/opt //caffe2/benchmarks/dynamo:torchbench_internal -- --only mrs_video_watch_over --performance --training --amp --export-profiler-trace --backend=inductor --profile-details --export-perfdoctor ``` https://interncache-all.fbcdn.net/manifold/perfetto-artifacts/tree/ui/index.html#!/?url=https://interncache-all.fbcdn.net/manifold/pyper_traces/tree/traces/test/inductor_mrs_video_watch_over_rank_0_20250113_173817_6535183793.json.gz Differential Revision: D68134547
xuzhao9
added a commit
to xuzhao9/pytorch
that referenced
this pull request
Jan 16, 2025
…torch#144751) Summary: X-link: pytorch/benchmark#2565 Add `--profile-details` option to add shapes and other details to the Kineto profile. Add `--export-perfdoctor` to directly dump trace to perfdoctor for webview. Test Plan: ``` $ buck2 run mode/opt //caffe2/benchmarks/dynamo:torchbench_internal -- --only mrs_video_watch_over --performance --training --amp --export-profiler-trace --backend=inductor --profile-details --export-perfdoctor ``` https://interncache-all.fbcdn.net/manifold/perfetto-artifacts/tree/ui/index.html#!/?url=https://interncache-all.fbcdn.net/manifold/pyper_traces/tree/traces/test/inductor_mrs_video_watch_over_rank_0_20250113_173817_6535183793.json.gz Differential Revision: D68134547
Summary: X-link: pytorch/pytorch#144751 Add `--profile-details` option to add shapes and other details to the Kineto profile. Add `--export-perfdoctor` to directly dump trace to perfdoctor for webview. Differential Revision: D68134547
xuzhao9
force-pushed
the
export-D68134547
branch
from
January 16, 2025 01:30
61586de
to
fb8dd28
Compare
This pull request was exported from Phabricator. Differential Revision: D68134547 |
xuzhao9
had a problem deploying
to
docker-s3-upload
January 16, 2025 01:30 — with
GitHub Actions
Failure
xuzhao9
temporarily deployed
to
docker-s3-upload
January 16, 2025 01:30 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add
--profile-details
option to add shapes and other details to the Kineto profile.Add
--export-perfdoctor
to directly dump trace to perfdoctor for webview.Differential Revision: D68134547