Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AMI pinning to al2023-ami-2023.6.* #320

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Update AMI pinning to al2023-ami-2023.6.* #320

merged 1 commit into from
Jan 13, 2025

Conversation

jeanschmidt
Copy link
Contributor

update the AMI pinning so it reflects what is already on pytorch-labs/pytorch-gha-infra and is on all variants of scale-config.yml

@jeanschmidt jeanschmidt merged commit f564bcf into main Jan 13, 2025
9 checks passed
@jeanschmidt jeanschmidt deleted the jeanschmidt/update_ami_pinning branch January 13, 2025 17:42
malfet
malfet reviewed Jan 13, 2025
View reviewed changes
Copy link

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any docs what this change supposed to be doing, especially the amzn2->al2023 part?

@jeanschmidt
Copy link
Contributor Author

jeanschmidt commented Jan 13, 2025 •
edited
Loading

@malfet just outdated code that was not updated due to laziness after the migration to amzn2023.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malfet malfet malfet left review comments

@huydhn huydhn huydhn approved these changes

@zxiiro zxiiro Awaiting requested review from zxiiro zxiiro is a code owner

@ZainRizvi ZainRizvi Awaiting requested review from ZainRizvi ZainRizvi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeanschmidt @huydhn @malfet