Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs and CI for py 3.13 support #1354

Merged
merged 3 commits into from
Nov 6, 2024
Merged

Conversation

andrewkho
Copy link
Contributor

@andrewkho andrewkho commented Nov 6, 2024

Enabling 3.13 CI for main/nightly, unsure if this needs more work for FTPython. Only enabled for Linux for now, as torch nightly does not yet have 3.13 for macos/windows

Fixes #1342

Changes

Update READMEs and CI to reflect 3.13 support

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 6, 2024
Copy link

pytorch-bot bot commented Nov 6, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/data/1354

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Pending

As of commit 5235ea8 with merge base b255542 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

- os: macos-latest
python-version: "3.13"
- os: windows-latest
python-versino: "3.13"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be python-version.

- os: macos-latest
python-version: "3.13"
- os: windows-latest
python-versino: "3.13"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be python-version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

Copy link
Contributor

@divyanshk divyanshk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment to address, overall LGTM! Thank you..

@andrewkho
Copy link
Contributor Author

andrewkho commented Nov 6, 2024

ManyLinux test failure is unrelated, see pytorch/pytorch#123649

@andrewkho andrewkho merged commit 137ac45 into main Nov 6, 2024
43 of 45 checks passed
@andrewkho andrewkho deleted the andrewkh/add-py313-support branch November 6, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump python support to 3.13 experimental
3 participants