-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs and CI for py 3.13 support #1354
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/data/1354
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 PendingAs of commit 5235ea8 with merge base b255542 (): NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
- os: macos-latest | ||
python-version: "3.13" | ||
- os: windows-latest | ||
python-versino: "3.13" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be python-version
.
.github/workflows/nodes_ci.yml
Outdated
- os: macos-latest | ||
python-version: "3.13" | ||
- os: windows-latest | ||
python-versino: "3.13" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be python-version
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment to address, overall LGTM! Thank you..
ManyLinux test failure is unrelated, see pytorch/pytorch#123649 |
Enabling 3.13 CI for main/nightly, unsure if this needs more work for FTPython. Only enabled for Linux for now, as torch nightly does not yet have 3.13 for macos/windows
Fixes #1342
Changes
Update READMEs and CI to reflect 3.13 support