Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete conda builds #1367

Merged
merged 21 commits into from
Nov 25, 2024
Merged

Delete conda builds #1367

merged 21 commits into from
Nov 25, 2024

Conversation

ramanishsingh
Copy link
Contributor

@ramanishsingh ramanishsingh commented Nov 15, 2024 •
edited
Loading

PyTorch Core is deprecating Nightly Conda builds.
This PR aims to delete conda builds
Fixes #1365

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 15, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/data/1367

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure

As of commit 501a9e9 with merge base db03884 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 15, 2024
andrewkho and others added 2 commits November 15, 2024 14:29
@andrewkho @ramanishsingh
Update README.md (#1366)
e3507f9 
* Update README.md

* Update README.md
@ramanishsingh
revert changes
8e1d4d3
@ramanishsingh ramanishsingh changed the title Delete conda nightly builds Delete conda builds Nov 19, 2024
andrewkho
andrewkho reviewed Nov 20, 2024
View reviewed changes
.github/workflows/pull_release.yml
Comment on lines +10 to +13
permissions:
contents: write
id-token: write

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was getting this error

The workflow is not valid. .github/workflows/pull_release.yml (Line: 11, Col: 3): Error calling workflow 'pytorch/data/.github/workflows/_build_test_upload.yml@45dc471d9a16eb4cf482f38b9167f99a13cd55d4'. The workflow is requesting 'contents: write, id-token: write', but is only allowed 'contents: read, id-token: none'.

https://github.com/pytorch/data/actions/runs/11864790565

After I added these lines it worked. I can try to again remove these and see what happens now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes this maybe needed

atalman
atalman reviewed Nov 20, 2024
View reviewed changes
packaging/post_build_script_linux.sh Outdated
@@ -7,8 +7,8 @@ for pkg in dist/torchdata*.whl; do
echo "PkgInfo of $pkg:"
pkginfo $pkg

auditwheel repair $pkg --plat manylinux2014_x86_64 -w wheelhouse
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we are mixing manylinux here and conda removal

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, updated (reverted).

@ramanishsingh ramanishsingh marked this pull request as ready for review November 20, 2024 16:37
andrewkho
andrewkho approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@andrewkho andrewkho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

atalman
atalman approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@facebook-github-bot
Copy link
Contributor

@ramanishsingh has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@ramanishsingh ramanishsingh merged commit 31291ef into main Nov 25, 2024
54 of 55 checks passed
@ramanishsingh ramanishsingh deleted the dlt_conda_builds branch December 12, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atalman atalman atalman approved these changes

@andrewkho andrewkho andrewkho approved these changes

@divyanshk divyanshk Awaiting requested review from divyanshk

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Release] Delete Conda Nightly builds
4 participants
@ramanishsingh @facebook-github-bot @andrewkho @atalman