Exclude 3.13 for windows on release v10 #1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/data/1386
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 006bd53 with merge base 075661c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
andrewkho
approved these changes
Dec 7, 2024
divyanshk
deleted the
divyanshk/exclude_3.13_for_windows_on_release_v10
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We tried to setup a test workflow for v10 release, but it failed because windows has no support for 3.13 in torch.
Flow: https://github.com/pytorch/data/actions/runs/12208526204/job/34061897521#step:8:300
We believe that is because the flow config
_build_test_upload.ymldoesn't exclude 3.13 for windows. This PR is adding that.I tried to test the workflow with this change by running the test release workflow on the branch
divyanshk/exclude_3.13_...but that doesn't work. Mostly because of the filtering rules built in the config (https://github.com/pytorch/data/actions/runs/12209869119/workflow#L31).Edit:
build_test_uploadgot kicked by this PR and succeeds https://github.com/pytorch/data/actions/runs/12210112227/job/34065795491?pr=1386 (i.e. excludes 3.13 and pure for windows)