-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new torchdata.nodes doc file #1390
Conversation
docs/source/torchdata.nodes.rst
Outdated
|
||
torchdata.nodes adds more flexibility to the standard torch.utils.data offering, and introduces multi-threaded parallelism in addition to multi-process (the only supported approach in torch.utils.data.DataLoader), as well as first-class support for mid-epoch checkpointing through a state_dict/load_state_dict interface. | ||
|
||
More information on torchdata.nodes can be found in the `README <https://github.com/pytorch/data/blob/main/torchdata/nodes/README.md>`_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we flip it and have README point here, and copy/paste most of the README here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah lets do that, let's keep it in both places for now ?
i'll also edit the main readme to include a section on nodes
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/data/1390
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 32ee5f7 with merge base aaeb157 (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks amazing!
Maybe for Tutorials/Examples we can have "Coming soon" or something for torchdata.nodes |
@andrewkho Would it look a little off if we had a mostly empty page for "Tutorials and Examples > torchdata.nodes". If feel we can just add the page when we have the tutorial ready (which I believe is fairly soon). What say ? I'll land this diff without it, but if you think we should add an empty page with "Coming soon!" do let me know, I'll create another PR. Also. I will add a note on tutorial coming soon in the overall README.md, so atleast that information is conveyed. |
* add new torchdata.nodes doc file * update main readme.md, move content of nodes readme.md to torchdata.nodes.rst * main readme * udpate readme
Clone the repo on local, created the environment, updated the
/docs
folder, thenmake html
andsphinx-serve -b build
.