fix g3 dequant #7683
Open
fix g3 dequant #7683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7683
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit 61a930f with merge base 1a6b7a6 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68109702 |
zonglinpeng
added a commit
to zonglinpeng/executorch
that referenced
this pull request
Jan 15, 2025
Summary: fix dequant signature. This is cadence::dequantize_per_tensor.out custom op so the function signatures are different. Eventually we would want to use the same signature as quantized_decomposed::* but that would require use to make this change for all backends. Reviewed By: hsharma35 Differential Revision: D68109702
zonglinpeng
force-pushed
the
export-D68109702
branch
from
9c39732 to
03efe44
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68109702 |
hsharma35
approved these changes
Jan 15, 2025
zonglinpeng
added a commit
to zonglinpeng/executorch
that referenced
this pull request
Jan 15, 2025
Summary: fix dequant signature. This is cadence::dequantize_per_tensor.out custom op so the function signatures are different. Eventually we would want to use the same signature as quantized_decomposed::* but that would require use to make this change for all backends. Reviewed By: hsharma35 Differential Revision: D68109702
zonglinpeng
force-pushed
the
export-D68109702
branch
from
03efe44 to
3a1a9f2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68109702 |
zonglinpeng
added a commit
to zonglinpeng/executorch
that referenced
this pull request
Jan 16, 2025
Summary: fix dequant signature. This is cadence::dequantize_per_tensor.out custom op so the function signatures are different. Eventually we would want to use the same signature as quantized_decomposed::* but that would require use to make this change for all backends. Reviewed By: hsharma35 Differential Revision: D68109702
zonglinpeng
force-pushed
the
export-D68109702
branch
from
229dd31 to
32b32f9
Compare
zonglinpeng
added a commit
to zonglinpeng/executorch
that referenced
this pull request
Jan 16, 2025
Summary: fix dequant signature. This is cadence::dequantize_per_tensor.out custom op so the function signatures are different. Eventually we would want to use the same signature as quantized_decomposed::* but that would require use to make this change for all backends. Reviewed By: hsharma35 Differential Revision: D68109702
zonglinpeng
force-pushed
the
export-D68109702
branch
from
32b32f9 to
a3ac712
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68109702 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D68109702 |
zonglinpeng
added a commit
to zonglinpeng/executorch
that referenced
this pull request
Jan 16, 2025
Summary: Pull Request resolved: pytorch#7683 fix dequant signature. This is cadence::dequantize_per_tensor.out custom op so the function signatures are different. Eventually we would want to use the same signature as quantized_decomposed::* but that would require use to make this change for all backends. Reviewed By: hsharma35 Differential Revision: D68109702
zonglinpeng
force-pushed
the
export-D68109702
branch
from
a3ac712 to
0a19531
Compare
zonglinpeng
added a commit
to zonglinpeng/executorch
that referenced
this pull request
Jan 16, 2025
Summary: fix dequant signature. This is cadence::dequantize_per_tensor.out custom op so the function signatures are different. Eventually we would want to use the same signature as quantized_decomposed::* but that would require use to make this change for all backends. Reviewed By: hsharma35 Differential Revision: D68109702
zonglinpeng
force-pushed
the
export-D68109702
branch
from
0a19531 to
ef8ff77
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68109702 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D68109702 |
zonglinpeng
added a commit
to zonglinpeng/executorch
that referenced
this pull request
Jan 16, 2025
Summary: Pull Request resolved: pytorch#7683 fix dequant signature. This is cadence::dequantize_per_tensor.out custom op so the function signatures are different. Eventually we would want to use the same signature as quantized_decomposed::* but that would require use to make this change for all backends. Reviewed By: hsharma35 Differential Revision: D68109702
zonglinpeng
force-pushed
the
export-D68109702
branch
from
1df39cb to
26fb017
Compare
|
@zonglinpeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
zonglinpeng
added a commit
to zonglinpeng/executorch
that referenced
this pull request
Jan 16, 2025
Summary: fix dequant signature Reviewed By: hsharma35 Differential Revision: D68109702 Pulled By: zonglinpeng
zonglinpeng
force-pushed
the
export-D68109702
branch
from
26fb017 to
f26bca2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68109702 |
zonglinpeng
added a commit
to zonglinpeng/executorch
that referenced
this pull request
Jan 17, 2025
Summary: fix dequant signature Reviewed By: hsharma35 Differential Revision: D68109702 Pulled By: zonglinpeng
zonglinpeng
force-pushed
the
export-D68109702
branch
from
f680a4a to
71c9175
Compare
Summary: fix dequant signature Reviewed By: hsharma35 Differential Revision: D68109702 Pulled By: zonglinpeng
|
This pull request was exported from Phabricator. Differential Revision: D68109702 |
zonglinpeng
force-pushed
the
export-D68109702
branch
from
71c9175 to
61a930f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68109702 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: fix dequant signature
Differential Revision: D68109702