install_requirements.py: reorganize requirements #7705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7705
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 2 PendingAs of commit a309d3d with merge base 1a6b7a6 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Jan 16, 2025
facebook-github-bot
added
the
CLA Signed
swolchok
added a commit
that referenced
this pull request
Jan 16, 2025
Duplicate requirements with the pyproject.toml > /dev/null One unique devel reqiurement > requirements-dev.txt Examples requirements > requirements-examples.txt Nightlies stayed in the script. Rationale: be as "normal" a Python project as seemed possible. Test Plan: install_requirements.sh in a clean venv succeeded ghstack-source-id: 115e64db5af146cadb72cd5ea8db739312752c83 ghstack-comment-id: 2596313740 Pull Request resolved: #7705
swolchok
changed the title
mcr229
reviewed
Jan 16, 2025
Comment on lines
-118
to
-127
| "cmake", # For building binary targets. | ||
| "pip>=23", # For building the pip package. | ||
| "pyyaml", # Imported by the kernel codegen tools. | ||
| "setuptools>=63", # For building the pip package. | ||
| "tomli", # Imported by extract_sources.py when using python < 3.11. | ||
| "wheel", # For building the pip package archive. | ||
| "zstd", # Imported by resolve_buck.py. |
There was a problem hiding this comment.
do these need to be added to requirements-dev.txt?
There was a problem hiding this comment.
no. they are in the pyproject.toml already.
requirements-dev.txt
Outdated
| @@ -0,0 +1,2 @@ | |||
| # For visualizing ExportedPrograms | |||
| ai-edge-model-explorer >= 0.1.16 | |||
There was a problem hiding this comment.
Don't need this anymore
This was referenced Jan 16, 2025
swolchok
added
the
release notes: build
mergennachin
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate requirements with the pyproject.toml > /dev/null
One unique devel reqiurement > requirements-dev.txt
Examples requirements > requirements-examples.txt
Nightlies stayed in the script.
Rationale: be as "normal" a Python project as seemed possible.
Test Plan: install_requirements.sh in a clean venv succeeded