Move setup.py/pip cmake-out to repo_root/cmake-out #7720
Conversation
|
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7720
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 PendingAs of commit f57ca18 with merge base 1a6b7a6 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Our setup.py/pip runs currently do CMake builds under the setup.py build_temp directory, which results in the build directory pip-out/temp.something/cmake-out. This does not share built artifacts with any of the other things that might do a CMake build, such as CI scripts, developers focused on C++, or users following the directions for an example or backend. I am not aware of any particular cost to just using the same cmake-out directory as everything else (please chime in if you are aware!) and there's a clear benefit, so let's try this? ghstack-source-id: 5a46e016a9f420fa3c9dd455c4342d6ed0a41285 ghstack-comment-id: 2597548020 Pull Request resolved: #7720
facebook-github-bot
added
the
CLA Signed
This PR needs a
|
zingo
requested review from
Erik-Lundell
and removed request for
Erik-Lundell
|
Note: CI seems bad, No PULL jobs had been running |
Our setup.py/pip runs currently do CMake builds under the setup.py build_temp directory, which results in the build directory pip-out/temp.something/cmake-out. This does not share built artifacts with any of the other things that might do a CMake build, such as CI scripts, developers focused on C++, or users following the directions for an example or backend. I am not aware of any particular cost to just using the same cmake-out directory as everything else (please chime in if you are aware!) and there's a clear benefit, so let's try this?