Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manual cherry-pick to update numpy as well as all dependencies #7727

Merged
merged 6 commits into from
Jan 17, 2025
Merged

Manual cherry-pick to update numpy as well as all dependencies #7727

merged 6 commits into from
Jan 17, 2025
+29 −35

Conversation

mergennachin
Copy link
Contributor

@mergennachin mergennachin commented Jan 17, 2025 •
edited
Loading

@mergennachin
Install torchao by default (#7470)
4750927 
Summary:

Now that torchao is not experimental anymore, we can rely on torchao directly via git submodule.

Part of #7460

(cherry picked from commit a861294)
@mergennachin
Upgrade numpy version requirement to 2.0 (#7599)
cf65801 
Upgrade numpy version requirement to

Summary:

1.21 is too old now. For 3.10 or above, we should be able to use 2.0.0

We are already on CoreMLTools 8.1, which is https://github.com/apple/coremltools/blob/8.1/reqs/build.pip

We had to upgrade to the latest transformers as well

(cherry picked from commit a7b5297)
@mergennachin
Update torchtune pin (#7670)
875143b 
(cherry picked from commit a18f6e8)
@mergennachin
[Arm] TOSA reference model update
1ed09ba
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jan 17, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7727

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 16 Pending

As of commit eb4529a with merge base 9069017 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 17, 2025
@mergennachin mergennachin mentioned this pull request Jan 17, 2025
Open
@mergennachin
Copy link
Contributor Author

mergennachin commented Jan 17, 2025 •
edited
Loading

@dvorjackz @SS-JIA

I just realized that we have to update the torchtune pin to release version, just like how we do for everything else (torch, torchaudio, torchvision etc)

Otherwise, even if we update the nightly pin, when someone uses the release binary in a few months, one of its dependencies, torchtune, will not be working

Initially I tried to cherry-pick (#7670), but later manually override with release version.

@SS-JIA
Copy link
Contributor

SS-JIA commented Jan 17, 2025

I just realized that we have to update the torchtune pin to release version, just like how we do for everything else (torch, torchaudio, torchvision etc)

Ah, got it. It seems that your diff seems to accomplish that; would I be correct to assume that the only next steps would be to update the release workflow to say that torchtune must be updated as well?

@mergennachin
Copy link
Contributor Author

would I be correct to assume that the only next steps would be to update the release workflow to say that torchtune must be updated as well?

Yes, that would be correct

@mergennachin mergennachin merged commit 5da6235 into release/0.5 Jan 17, 2025
113 of 119 checks passed
@mergennachin mergennachin deleted the my_fork branch January 17, 2025 18:20
dvorjackz
dvorjackz reviewed Jan 17, 2025
View reviewed changes
Copy link
Contributor

@dvorjackz dvorjackz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mergennachin yup should be fine as long as tests past

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvorjackz dvorjackz dvorjackz left review comments

@SS-JIA SS-JIA SS-JIA approved these changes

@digantdesai digantdesai Awaiting requested review from digantdesai

@per per Awaiting requested review from per

Assignees
No one assigned
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mergennachin @SS-JIA @dvorjackz @facebook-github-bot