Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ET-VK][ez] Fix linear weight int4 test due to change in ATen API #7739

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

SS-JIA
Copy link
Contributor

@SS-JIA SS-JIA commented Jan 17, 2025

Stack from ghstack (oldest at bottom):

Context

Recently the ATen API for 4-bit quantized linear has changed, so our test must adapt to the change in API.

Concretely, the changes in API were:

  • The _for_cpu suffix was added to the operator name
  • The _convert_weight_to_int4pack_mm operator now expects unpacked 4-bit weights instead of a packed scheme where 2 4-bit values are packed into a single 8-bit value.

Differential Revision: D68333687

## Context

Recently the ATen API for 4-bit quantized linear has changed, so our test must adapt to the change in API.

Concretely, the changes in API were:

* The `_for_cpu` suffix was added to the operator name
* The `_convert_weight_to_int4pack_mm` operator now expects unpacked 4-bit weights instead of a packed scheme where 2 4-bit values are packed into a single 8-bit value.

Differential Revision: [D68333687](https://our.internmc.facebook.com/intern/diff/D68333687/)

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Jan 17, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7739

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 1 Pending

As of commit b9c38a2 with merge base 1a6b7a6 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 17, 2025
SS-JIA added a commit that referenced this pull request Jan 17, 2025
## Context

Recently the ATen API for 4-bit quantized linear has changed, so our test must adapt to the change in API.

Concretely, the changes in API were:

* The `_for_cpu` suffix was added to the operator name
* The `_convert_weight_to_int4pack_mm` operator now expects unpacked 4-bit weights instead of a packed scheme where 2 4-bit values are packed into a single 8-bit value.

Differential Revision: [D68333687](https://our.internmc.facebook.com/intern/diff/D68333687/)

ghstack-source-id: 261917427
Pull Request resolved: #7739
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68333687

…Ten API"

## Context

Recently the ATen API for 4-bit quantized linear has changed, so our test must adapt to the change in API.

Concretely, the changes in API were:

* The `_for_cpu` suffix was added to the operator name
* The `_convert_weight_to_int4pack_mm` operator now expects unpacked 4-bit weights instead of a packed scheme where 2 4-bit values are packed into a single 8-bit value.

Differential Revision: [D68333687](https://our.internmc.facebook.com/intern/diff/D68333687/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68333687

SS-JIA added a commit that referenced this pull request Jan 17, 2025
Pull Request resolved: #7739

## Context

Recently the ATen API for 4-bit quantized linear has changed, so our test must adapt to the change in API.

Concretely, the changes in API were:

* The `_for_cpu` suffix was added to the operator name
* The `_convert_weight_to_int4pack_mm` operator now expects unpacked 4-bit weights instead of a packed scheme where 2 4-bit values are packed into a single 8-bit value.
ghstack-source-id: 261959346
@exported-using-ghexport

Differential Revision: [D68333687](https://our.internmc.facebook.com/intern/diff/D68333687/)
@facebook-github-bot facebook-github-bot merged commit b230fcf into gh/SS-JIA/170/base Jan 17, 2025
10 of 12 checks passed
@facebook-github-bot facebook-github-bot deleted the gh/SS-JIA/170/head branch January 17, 2025 23:48
SS-JIA added a commit that referenced this pull request Jan 17, 2025
)

Pull Request resolved: #7739

## Context

Recently the ATen API for 4-bit quantized linear has changed, so our test must adapt to the change in API.

Concretely, the changes in API were:

* The `_for_cpu` suffix was added to the operator name
* The `_convert_weight_to_int4pack_mm` operator now expects unpacked 4-bit weights instead of a packed scheme where 2 4-bit values are packed into a single 8-bit value.
ghstack-source-id: 261959346
@exported-using-ghexport

Differential Revision: [D68333687](https://our.internmc.facebook.com/intern/diff/D68333687/)

Co-authored-by: Stephen Jia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants