Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] tensordict._tensordict -> tensordict._C #2286

Merged
merged 1 commit into from
Jul 10, 2024
Merged

[Refactor] tensordict._tensordict -> tensordict._C #2286

merged 1 commit into from
Jul 10, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Jul 10, 2024

No description provided.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 10, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2286

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 16 Unrelated Failures

As of commit 86f4108 with merge base a0a47a9 (image):

NEW FAILURE - The following job has failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 10, 2024
@vmoens vmoens merged commit 28acf61 into main Jul 10, 2024
11 of 20 checks passed
@vmoens vmoens added the Refactoring Refactoring of an existing feature label Jul 10, 2024
@vmoens vmoens deleted the minor-td-import-deprec branch July 10, 2024 10:51
@github-actions GitHub Actions
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 91. Improved: $\large\color{#35bf28}4$. Worsened: $\large\color{#d91a1a}2$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1090s 58.3406ms 17.1407 Ops/s 17.9220 Ops/s $\color{#d91a1a}-4.36\%$
test_sync 43.4332ms 31.6710ms 31.5746 Ops/s 28.4353 Ops/s $\textbf{\color{#35bf28}+11.04\%}$
test_async 54.1839ms 28.5829ms 34.9859 Ops/s 34.3274 Ops/s $\color{#35bf28}+1.92\%$
test_simple 0.4524s 0.3903s 2.5623 Ops/s 2.6254 Ops/s $\color{#d91a1a}-2.40\%$
test_transformed 0.5959s 0.5463s 1.8304 Ops/s 1.8389 Ops/s $\color{#d91a1a}-0.46\%$
test_serial 1.3194s 1.2629s 0.7918 Ops/s 0.7829 Ops/s $\color{#35bf28}+1.14\%$
test_parallel 1.1624s 1.0995s 0.9095 Ops/s 0.9115 Ops/s $\color{#d91a1a}-0.21\%$
test_step_mdp_speed[True-True-True-True-True] 0.2098ms 22.4280μs 44.5872 KOps/s 44.5980 KOps/s $\color{#d91a1a}-0.02\%$
test_step_mdp_speed[True-True-True-True-False] 43.1210μs 13.1915μs 75.8064 KOps/s 74.5063 KOps/s $\color{#35bf28}+1.74\%$
test_step_mdp_speed[True-True-True-False-True] 43.6020μs 12.8503μs 77.8191 KOps/s 75.8499 KOps/s $\color{#35bf28}+2.60\%$
test_step_mdp_speed[True-True-True-False-False] 28.8040μs 7.6591μs 130.5634 KOps/s 126.0340 KOps/s $\color{#35bf28}+3.59\%$
test_step_mdp_speed[True-True-False-True-True] 57.4170μs 23.8370μs 41.9516 KOps/s 42.0498 KOps/s $\color{#d91a1a}-0.23\%$
test_step_mdp_speed[True-True-False-True-False] 57.9360μs 14.4299μs 69.3006 KOps/s 68.6633 KOps/s $\color{#35bf28}+0.93\%$
test_step_mdp_speed[True-True-False-False-True] 45.3150μs 14.0324μs 71.2636 KOps/s 69.4180 KOps/s $\color{#35bf28}+2.66\%$
test_step_mdp_speed[True-True-False-False-False] 39.2140μs 8.8543μs 112.9392 KOps/s 110.3491 KOps/s $\color{#35bf28}+2.35\%$
test_step_mdp_speed[True-False-True-True-True] 60.3330μs 25.2002μs 39.6823 KOps/s 39.4743 KOps/s $\color{#35bf28}+0.53\%$
test_step_mdp_speed[True-False-True-True-False] 43.4910μs 15.6852μs 63.7545 KOps/s 61.8967 KOps/s $\color{#35bf28}+3.00\%$
test_step_mdp_speed[True-False-True-False-True] 36.6090μs 14.2152μs 70.3474 KOps/s 69.5138 KOps/s $\color{#35bf28}+1.20\%$
test_step_mdp_speed[True-False-True-False-False] 34.8650μs 8.8815μs 112.5936 KOps/s 109.3211 KOps/s $\color{#35bf28}+2.99\%$
test_step_mdp_speed[True-False-False-True-True] 64.5010μs 26.2510μs 38.0938 KOps/s 37.4001 KOps/s $\color{#35bf28}+1.85\%$
test_step_mdp_speed[True-False-False-True-False] 41.8680μs 16.9539μs 58.9833 KOps/s 57.1985 KOps/s $\color{#35bf28}+3.12\%$
test_step_mdp_speed[True-False-False-False-True] 55.1130μs 15.2414μs 65.6109 KOps/s 64.4713 KOps/s $\color{#35bf28}+1.77\%$
test_step_mdp_speed[True-False-False-False-False] 32.2910μs 10.1349μs 98.6687 KOps/s 96.9171 KOps/s $\color{#35bf28}+1.81\%$
test_step_mdp_speed[False-True-True-True-True] 51.8670μs 25.0216μs 39.9655 KOps/s 39.9596 KOps/s $\color{#35bf28}+0.01\%$
test_step_mdp_speed[False-True-True-True-False] 42.4600μs 15.7738μs 63.3964 KOps/s 61.8461 KOps/s $\color{#35bf28}+2.51\%$
test_step_mdp_speed[False-True-True-False-True] 45.3550μs 16.4540μs 60.7755 KOps/s 59.5750 KOps/s $\color{#35bf28}+2.02\%$
test_step_mdp_speed[False-True-True-False-False] 35.8070μs 10.2072μs 97.9705 KOps/s 96.9703 KOps/s $\color{#35bf28}+1.03\%$
test_step_mdp_speed[False-True-False-True-True] 56.3050μs 26.1961μs 38.1737 KOps/s 37.4119 KOps/s $\color{#35bf28}+2.04\%$
test_step_mdp_speed[False-True-False-True-False] 49.2320μs 16.8180μs 59.4601 KOps/s 57.0971 KOps/s $\color{#35bf28}+4.14\%$
test_step_mdp_speed[False-True-False-False-True] 43.1300μs 17.9023μs 55.8586 KOps/s 55.3995 KOps/s $\color{#35bf28}+0.83\%$
test_step_mdp_speed[False-True-False-False-False] 33.1620μs 11.4124μs 87.6239 KOps/s 87.2401 KOps/s $\color{#35bf28}+0.44\%$
test_step_mdp_speed[False-False-True-True-True] 57.5670μs 27.5458μs 36.3032 KOps/s 35.6797 KOps/s $\color{#35bf28}+1.75\%$
test_step_mdp_speed[False-False-True-True-False] 44.9540μs 18.2585μs 54.7691 KOps/s 53.6899 KOps/s $\color{#35bf28}+2.01\%$
test_step_mdp_speed[False-False-True-False-True] 41.7680μs 17.8814μs 55.9242 KOps/s 55.9449 KOps/s $\color{#d91a1a}-0.04\%$
test_step_mdp_speed[False-False-True-False-False] 35.8670μs 11.4230μs 87.5429 KOps/s 86.3462 KOps/s $\color{#35bf28}+1.39\%$
test_step_mdp_speed[False-False-False-True-True] 40.8360μs 28.9887μs 34.4962 KOps/s 33.7653 KOps/s $\color{#35bf28}+2.16\%$
test_step_mdp_speed[False-False-False-True-False] 58.2390μs 19.5669μs 51.1068 KOps/s 50.3581 KOps/s $\color{#35bf28}+1.49\%$
test_step_mdp_speed[False-False-False-False-True] 52.3180μs 18.6977μs 53.4825 KOps/s 52.2021 KOps/s $\color{#35bf28}+2.45\%$
test_step_mdp_speed[False-False-False-False-False] 49.4730μs 12.4311μs 80.4433 KOps/s 80.0418 KOps/s $\color{#35bf28}+0.50\%$
test_values[generalized_advantage_estimate-True-True] 9.8410ms 9.3582ms 106.8577 Ops/s 106.1727 Ops/s $\color{#35bf28}+0.65\%$
test_values[vec_generalized_advantage_estimate-True-True] 50.7469ms 35.6056ms 28.0855 Ops/s 28.5477 Ops/s $\color{#d91a1a}-1.62\%$
test_values[td0_return_estimate-False-False] 0.2275ms 0.1677ms 5.9616 KOps/s 6.0175 KOps/s $\color{#d91a1a}-0.93\%$
test_values[td1_return_estimate-False-False] 26.1307ms 23.3219ms 42.8781 Ops/s 41.5749 Ops/s $\color{#35bf28}+3.13\%$
test_values[vec_td1_return_estimate-False-False] 38.1422ms 35.3615ms 28.2793 Ops/s 28.2358 Ops/s $\color{#35bf28}+0.15\%$
test_values[td_lambda_return_estimate-True-False] 41.6950ms 33.7998ms 29.5859 Ops/s 28.7884 Ops/s $\color{#35bf28}+2.77\%$
test_values[vec_td_lambda_return_estimate-True-False] 37.7772ms 35.4766ms 28.1876 Ops/s 28.3320 Ops/s $\color{#d91a1a}-0.51\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 8.4732ms 8.2513ms 121.1937 Ops/s 119.9892 Ops/s $\color{#35bf28}+1.00\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 2.3987ms 1.9351ms 516.7565 Ops/s 510.6046 Ops/s $\color{#35bf28}+1.20\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.5413ms 0.3471ms 2.8806 KOps/s 2.7817 KOps/s $\color{#35bf28}+3.56\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 46.1170ms 44.8884ms 22.2775 Ops/s 22.4211 Ops/s $\color{#d91a1a}-0.64\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 4.0770ms 3.0187ms 331.2673 Ops/s 327.8730 Ops/s $\color{#35bf28}+1.04\%$
test_dqn_speed 6.0349ms 1.3554ms 737.8140 Ops/s 753.7247 Ops/s $\color{#d91a1a}-2.11\%$
test_ddpg_speed 3.6767ms 2.8539ms 350.3926 Ops/s 355.9706 Ops/s $\color{#d91a1a}-1.57\%$
test_sac_speed 9.7983ms 8.5269ms 117.2761 Ops/s 118.0400 Ops/s $\color{#d91a1a}-0.65\%$
test_redq_speed 15.6220ms 13.5562ms 73.7671 Ops/s 74.4296 Ops/s $\color{#d91a1a}-0.89\%$
test_redq_deprec_speed 15.3641ms 14.1953ms 70.4457 Ops/s 69.4333 Ops/s $\color{#35bf28}+1.46\%$
test_td3_speed 8.6924ms 8.4495ms 118.3496 Ops/s 120.2991 Ops/s $\color{#d91a1a}-1.62\%$
test_cql_speed 40.0526ms 37.0975ms 26.9560 Ops/s 27.4992 Ops/s $\color{#d91a1a}-1.98\%$
test_a2c_speed 8.6317ms 7.4516ms 134.1993 Ops/s 134.4189 Ops/s $\color{#d91a1a}-0.16\%$
test_ppo_speed 8.5287ms 7.7372ms 129.2460 Ops/s 130.0918 Ops/s $\color{#d91a1a}-0.65\%$
test_reinforce_speed 8.0101ms 6.6256ms 150.9298 Ops/s 150.0720 Ops/s $\color{#35bf28}+0.57\%$
test_iql_speed 33.9826ms 32.3658ms 30.8968 Ops/s 30.6617 Ops/s $\color{#35bf28}+0.77\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 5.5902ms 3.5351ms 282.8781 Ops/s 281.2520 Ops/s $\color{#35bf28}+0.58\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 95.0815ms 0.5655ms 1.7683 KOps/s 1.9944 KOps/s $\textbf{\color{#d91a1a}-11.34\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.8695ms 0.4748ms 2.1060 KOps/s 2.0956 KOps/s $\color{#35bf28}+0.50\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.9339ms 3.5176ms 284.2823 Ops/s 286.5658 Ops/s $\color{#d91a1a}-0.80\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.1454ms 0.4976ms 2.0097 KOps/s 2.0491 KOps/s $\color{#d91a1a}-1.92\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.8734ms 0.4715ms 2.1209 KOps/s 2.1327 KOps/s $\color{#d91a1a}-0.55\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 2.6030ms 1.7199ms 581.4351 Ops/s 578.5967 Ops/s $\color{#35bf28}+0.49\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 8.5032ms 1.6419ms 609.0491 Ops/s 608.0391 Ops/s $\color{#35bf28}+0.17\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 4.1869ms 3.6742ms 272.1669 Ops/s 273.1615 Ops/s $\color{#d91a1a}-0.36\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.9568ms 0.6343ms 1.5767 KOps/s 1.3887 KOps/s $\textbf{\color{#35bf28}+13.54\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 1.0122ms 0.6129ms 1.6317 KOps/s 1.6563 KOps/s $\color{#d91a1a}-1.48\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 4.0224ms 3.5020ms 285.5515 Ops/s 281.0246 Ops/s $\color{#35bf28}+1.61\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.6234ms 0.4991ms 2.0036 KOps/s 1.9813 KOps/s $\color{#35bf28}+1.12\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6173ms 0.4790ms 2.0875 KOps/s 2.1060 KOps/s $\color{#d91a1a}-0.88\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.7544ms 3.4934ms 286.2567 Ops/s 282.0058 Ops/s $\color{#35bf28}+1.51\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.0404ms 0.5036ms 1.9858 KOps/s 2.0301 KOps/s $\color{#d91a1a}-2.18\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6668ms 0.4706ms 2.1247 KOps/s 2.0657 KOps/s $\color{#35bf28}+2.86\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 5.8655ms 3.7233ms 268.5825 Ops/s 272.2742 Ops/s $\color{#d91a1a}-1.36\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.0002ms 0.6414ms 1.5590 KOps/s 1.5828 KOps/s $\color{#d91a1a}-1.50\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 7.5073ms 0.6205ms 1.6116 KOps/s 1.6301 KOps/s $\color{#d91a1a}-1.14\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1237s 6.0640ms 164.9087 Ops/s 163.5361 Ops/s $\color{#35bf28}+0.84\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 0.1186s 14.8859ms 67.1778 Ops/s 78.0269 Ops/s $\textbf{\color{#d91a1a}-13.90\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 1.5887ms 1.0173ms 983.0189 Ops/s 987.6832 Ops/s $\color{#d91a1a}-0.47\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1056s 5.7011ms 175.4047 Ops/s 127.8226 Ops/s $\textbf{\color{#35bf28}+37.23\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 25.2033ms 13.3358ms 74.9863 Ops/s 78.7285 Ops/s $\color{#d91a1a}-4.75\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 1.6682ms 1.0308ms 970.1646 Ops/s 897.2509 Ops/s $\textbf{\color{#35bf28}+8.13\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1075s 5.8373ms 171.3124 Ops/s 167.6070 Ops/s $\color{#35bf28}+2.21\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 16.9356ms 12.9460ms 77.2439 Ops/s 77.5676 Ops/s $\color{#d91a1a}-0.42\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 1.7861ms 1.1769ms 849.6966 Ops/s 844.4437 Ops/s $\color{#35bf28}+0.62\%$

@github-actions GitHub Actions
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 94. Improved: $\large\color{#35bf28}2$. Worsened: $\large\color{#d91a1a}4$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1637s 0.1104s 9.0558 Ops/s 9.4705 Ops/s $\color{#d91a1a}-4.38\%$
test_sync 94.4828ms 92.7925ms 10.7767 Ops/s 11.3673 Ops/s $\textbf{\color{#d91a1a}-5.19\%}$
test_async 0.1749s 88.3387ms 11.3201 Ops/s 11.8204 Ops/s $\color{#d91a1a}-4.23\%$
test_single_pixels 0.1146s 0.1143s 8.7452 Ops/s 8.6413 Ops/s $\color{#35bf28}+1.20\%$
test_sync_pixels 71.0895ms 69.4009ms 14.4090 Ops/s 14.3859 Ops/s $\color{#35bf28}+0.16\%$
test_async_pixels 0.1254s 56.7684ms 17.6154 Ops/s 17.0082 Ops/s $\color{#35bf28}+3.57\%$
test_simple 0.7394s 0.7389s 1.3534 Ops/s 1.3283 Ops/s $\color{#35bf28}+1.89\%$
test_transformed 0.9820s 0.9748s 1.0258 Ops/s 1.0090 Ops/s $\color{#35bf28}+1.67\%$
test_serial 2.2699s 2.2402s 0.4464 Ops/s 0.4554 Ops/s $\color{#d91a1a}-1.97\%$
test_parallel 1.9098s 1.8616s 0.5372 Ops/s 0.5424 Ops/s $\color{#d91a1a}-0.97\%$
test_step_mdp_speed[True-True-True-True-True] 89.2910μs 33.5053μs 29.8460 KOps/s 29.0830 KOps/s $\color{#35bf28}+2.62\%$
test_step_mdp_speed[True-True-True-True-False] 40.2400μs 19.5016μs 51.2778 KOps/s 50.8495 KOps/s $\color{#35bf28}+0.84\%$
test_step_mdp_speed[True-True-True-False-True] 37.6900μs 19.5248μs 51.2169 KOps/s 52.4250 KOps/s $\color{#d91a1a}-2.30\%$
test_step_mdp_speed[True-True-True-False-False] 25.4410μs 11.0471μs 90.5211 KOps/s 89.8957 KOps/s $\color{#35bf28}+0.70\%$
test_step_mdp_speed[True-True-False-True-True] 62.0120μs 35.7027μs 28.0091 KOps/s 27.8102 KOps/s $\color{#35bf28}+0.72\%$
test_step_mdp_speed[True-True-False-True-False] 48.4300μs 21.2341μs 47.0940 KOps/s 46.5875 KOps/s $\color{#35bf28}+1.09\%$
test_step_mdp_speed[True-True-False-False-True] 41.3020μs 21.5488μs 46.4064 KOps/s 47.6302 KOps/s $\color{#d91a1a}-2.57\%$
test_step_mdp_speed[True-True-False-False-False] 30.6710μs 13.0484μs 76.6377 KOps/s 76.0659 KOps/s $\color{#35bf28}+0.75\%$
test_step_mdp_speed[True-False-True-True-True] 63.4520μs 38.3248μs 26.0927 KOps/s 26.3035 KOps/s $\color{#d91a1a}-0.80\%$
test_step_mdp_speed[True-False-True-True-False] 47.9810μs 23.4610μs 42.6240 KOps/s 42.2332 KOps/s $\color{#35bf28}+0.93\%$
test_step_mdp_speed[True-False-True-False-True] 50.1120μs 21.7106μs 46.0603 KOps/s 46.8274 KOps/s $\color{#d91a1a}-1.64\%$
test_step_mdp_speed[True-False-True-False-False] 61.5110μs 13.0533μs 76.6090 KOps/s 76.2222 KOps/s $\color{#35bf28}+0.51\%$
test_step_mdp_speed[True-False-False-True-True] 62.3110μs 40.4985μs 24.6923 KOps/s 24.9260 KOps/s $\color{#d91a1a}-0.94\%$
test_step_mdp_speed[True-False-False-True-False] 39.5000μs 25.0998μs 39.8410 KOps/s 39.3046 KOps/s $\color{#35bf28}+1.36\%$
test_step_mdp_speed[True-False-False-False-True] 43.5010μs 23.3182μs 42.8850 KOps/s 43.2730 KOps/s $\color{#d91a1a}-0.90\%$
test_step_mdp_speed[True-False-False-False-False] 42.4110μs 14.8563μs 67.3115 KOps/s 66.3546 KOps/s $\color{#35bf28}+1.44\%$
test_step_mdp_speed[False-True-True-True-True] 84.0320μs 38.2833μs 26.1211 KOps/s 26.1414 KOps/s $\color{#d91a1a}-0.08\%$
test_step_mdp_speed[False-True-True-True-False] 43.3200μs 23.5217μs 42.5139 KOps/s 42.4400 KOps/s $\color{#35bf28}+0.17\%$
test_step_mdp_speed[False-True-True-False-True] 43.5810μs 25.2812μs 39.5551 KOps/s 39.9905 KOps/s $\color{#d91a1a}-1.09\%$
test_step_mdp_speed[False-True-True-False-False] 31.0210μs 14.9320μs 66.9702 KOps/s 67.1191 KOps/s $\color{#d91a1a}-0.22\%$
test_step_mdp_speed[False-True-False-True-True] 67.2720μs 39.9924μs 25.0047 KOps/s 24.7266 KOps/s $\color{#35bf28}+1.12\%$
test_step_mdp_speed[False-True-False-True-False] 61.8520μs 25.2449μs 39.6119 KOps/s 39.0180 KOps/s $\color{#35bf28}+1.52\%$
test_step_mdp_speed[False-True-False-False-True] 47.3700μs 27.1620μs 36.8161 KOps/s 37.2604 KOps/s $\color{#d91a1a}-1.19\%$
test_step_mdp_speed[False-True-False-False-False] 34.6110μs 16.7046μs 59.8636 KOps/s 60.0415 KOps/s $\color{#d91a1a}-0.30\%$
test_step_mdp_speed[False-False-True-True-True] 0.2176ms 42.0897μs 23.7588 KOps/s 23.7704 KOps/s $\color{#d91a1a}-0.05\%$
test_step_mdp_speed[False-False-True-True-False] 0.2073ms 27.3666μs 36.5408 KOps/s 36.2599 KOps/s $\color{#35bf28}+0.77\%$
test_step_mdp_speed[False-False-True-False-True] 91.5310μs 27.0281μs 36.9985 KOps/s 36.9627 KOps/s $\color{#35bf28}+0.10\%$
test_step_mdp_speed[False-False-True-False-False] 36.6610μs 16.8399μs 59.3829 KOps/s 59.3365 KOps/s $\color{#35bf28}+0.08\%$
test_step_mdp_speed[False-False-False-True-True] 75.8720μs 44.1170μs 22.6670 KOps/s 22.7369 KOps/s $\color{#d91a1a}-0.31\%$
test_step_mdp_speed[False-False-False-True-False] 49.0120μs 28.8194μs 34.6989 KOps/s 34.0027 KOps/s $\color{#35bf28}+2.05\%$
test_step_mdp_speed[False-False-False-False-True] 50.4810μs 28.8741μs 34.6332 KOps/s 34.9266 KOps/s $\color{#d91a1a}-0.84\%$
test_step_mdp_speed[False-False-False-False-False] 48.8100μs 18.6035μs 53.7534 KOps/s 54.1847 KOps/s $\color{#d91a1a}-0.80\%$
test_values[generalized_advantage_estimate-True-True] 26.9125ms 25.4472ms 39.2971 Ops/s 39.9774 Ops/s $\color{#d91a1a}-1.70\%$
test_values[vec_generalized_advantage_estimate-True-True] 96.7837ms 2.8414ms 351.9388 Ops/s 351.6326 Ops/s $\color{#35bf28}+0.09\%$
test_values[td0_return_estimate-False-False] 90.2120μs 66.7126μs 14.9897 KOps/s 14.9594 KOps/s $\color{#35bf28}+0.20\%$
test_values[td1_return_estimate-False-False] 60.3372ms 58.7727ms 17.0147 Ops/s 18.0363 Ops/s $\textbf{\color{#d91a1a}-5.66\%}$
test_values[vec_td1_return_estimate-False-False] 1.3092ms 1.0942ms 913.9239 Ops/s 919.0442 Ops/s $\color{#d91a1a}-0.56\%$
test_values[td_lambda_return_estimate-True-False] 94.3027ms 89.8784ms 11.1261 Ops/s 11.4513 Ops/s $\color{#d91a1a}-2.84\%$
test_values[vec_td_lambda_return_estimate-True-False] 1.3349ms 1.0914ms 916.2707 Ops/s 920.8322 Ops/s $\color{#d91a1a}-0.50\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 25.4215ms 25.2911ms 39.5396 Ops/s 39.9630 Ops/s $\color{#d91a1a}-1.06\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 0.9777ms 0.7322ms 1.3658 KOps/s 1.3815 KOps/s $\color{#d91a1a}-1.14\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.7761ms 0.6798ms 1.4710 KOps/s 1.4873 KOps/s $\color{#d91a1a}-1.10\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.5026ms 1.4778ms 676.6921 Ops/s 680.1261 Ops/s $\color{#d91a1a}-0.50\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.7426ms 0.6953ms 1.4383 KOps/s 1.4593 KOps/s $\color{#d91a1a}-1.44\%$
test_dqn_speed 79.9771ms 1.6135ms 619.7764 Ops/s 679.5901 Ops/s $\textbf{\color{#d91a1a}-8.80\%}$
test_ddpg_speed 3.3439ms 2.9964ms 333.7347 Ops/s 333.1763 Ops/s $\color{#35bf28}+0.17\%$
test_sac_speed 9.2096ms 8.5860ms 116.4685 Ops/s 117.1665 Ops/s $\color{#d91a1a}-0.60\%$
test_redq_speed 11.8932ms 10.9020ms 91.7262 Ops/s 90.8812 Ops/s $\color{#35bf28}+0.93\%$
test_redq_deprec_speed 12.3002ms 11.7752ms 84.9240 Ops/s 76.0014 Ops/s $\textbf{\color{#35bf28}+11.74\%}$
test_td3_speed 18.3858ms 8.6222ms 115.9793 Ops/s 118.0663 Ops/s $\color{#d91a1a}-1.77\%$
test_cql_speed 27.6404ms 26.3485ms 37.9529 Ops/s 38.1871 Ops/s $\color{#d91a1a}-0.61\%$
test_a2c_speed 6.2802ms 5.9862ms 167.0502 Ops/s 170.5358 Ops/s $\color{#d91a1a}-2.04\%$
test_ppo_speed 6.4446ms 6.1799ms 161.8162 Ops/s 162.2000 Ops/s $\color{#d91a1a}-0.24\%$
test_reinforce_speed 5.6122ms 4.8044ms 208.1430 Ops/s 209.7330 Ops/s $\color{#d91a1a}-0.76\%$
test_iql_speed 21.3323ms 20.4445ms 48.9130 Ops/s 49.3991 Ops/s $\color{#d91a1a}-0.98\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 4.7866ms 4.6440ms 215.3334 Ops/s 213.6896 Ops/s $\color{#35bf28}+0.77\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.3201ms 0.5485ms 1.8232 KOps/s 1.7906 KOps/s $\color{#35bf28}+1.82\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7261ms 0.5291ms 1.8899 KOps/s 1.8814 KOps/s $\color{#35bf28}+0.45\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 4.8188ms 4.6399ms 215.5215 Ops/s 217.3629 Ops/s $\color{#d91a1a}-0.85\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.4297ms 0.5446ms 1.8364 KOps/s 1.8494 KOps/s $\color{#d91a1a}-0.71\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7579ms 0.5204ms 1.9216 KOps/s 1.9366 KOps/s $\color{#d91a1a}-0.77\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 2.5662ms 2.0314ms 492.2686 Ops/s 494.5251 Ops/s $\color{#d91a1a}-0.46\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 2.0719ms 1.9261ms 519.1773 Ops/s 510.8676 Ops/s $\color{#35bf28}+1.63\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 4.8513ms 4.7371ms 211.1018 Ops/s 211.0435 Ops/s $\color{#35bf28}+0.03\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.3336ms 0.7061ms 1.4162 KOps/s 1.4266 KOps/s $\color{#d91a1a}-0.73\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8766ms 0.6715ms 1.4892 KOps/s 1.4592 KOps/s $\color{#35bf28}+2.06\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 4.7616ms 4.6151ms 216.6797 Ops/s 213.9350 Ops/s $\color{#35bf28}+1.28\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.7999ms 0.5471ms 1.8277 KOps/s 1.7980 KOps/s $\color{#35bf28}+1.65\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 4.4743ms 0.5323ms 1.8788 KOps/s 1.8430 KOps/s $\color{#35bf28}+1.94\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 4.7608ms 4.5677ms 218.9295 Ops/s 217.4513 Ops/s $\color{#35bf28}+0.68\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7581ms 0.5433ms 1.8407 KOps/s 1.8173 KOps/s $\color{#35bf28}+1.28\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6866ms 0.5245ms 1.9067 KOps/s 1.8896 KOps/s $\color{#35bf28}+0.90\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 4.9583ms 4.7769ms 209.3388 Ops/s 208.7597 Ops/s $\color{#35bf28}+0.28\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8337ms 0.6988ms 1.4310 KOps/s 1.4105 KOps/s $\color{#35bf28}+1.45\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 4.7991ms 0.6814ms 1.4675 KOps/s 1.4357 KOps/s $\color{#35bf28}+2.21\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1280s 7.3469ms 136.1117 Ops/s 133.4941 Ops/s $\color{#35bf28}+1.96\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 21.4723ms 15.8264ms 63.1857 Ops/s 65.0881 Ops/s $\color{#d91a1a}-2.92\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 2.2184ms 1.1387ms 878.1999 Ops/s 852.1023 Ops/s $\color{#35bf28}+3.06\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1265s 7.3093ms 136.8128 Ops/s 100.3676 Ops/s $\textbf{\color{#35bf28}+36.31\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 0.1384s 18.0969ms 55.2580 Ops/s 64.8363 Ops/s $\textbf{\color{#d91a1a}-14.77\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 2.4203ms 1.1887ms 841.2720 Ops/s 851.8462 Ops/s $\color{#d91a1a}-1.24\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1277s 7.5632ms 132.2198 Ops/s 131.8961 Ops/s $\color{#35bf28}+0.25\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 18.6624ms 16.0365ms 62.3577 Ops/s 64.5870 Ops/s $\color{#d91a1a}-3.45\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 2.4372ms 1.3337ms 749.7828 Ops/s 764.1232 Ops/s $\color{#d91a1a}-1.88\%$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Refactoring Refactoring of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot