-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Migrate seemethere/upload-artifact-s3 locally #6158
base: main
Are you sure you want to change the base?
Conversation
@jwagantall is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
Changes looks good to me in principle, but we should put some automation into building the actions and testing them, if they are part of test-infra on a personal repo |
f834a73
to
f7c800d
Compare
@@ -0,0 +1,273 @@ | |||
# Upload-Artifact v2 |
Check failure
Code scanning / lintrunner
TABS/saw some tabs
@@ -0,0 +1,273 @@ | |||
# Upload-Artifact v2 |
Check failure
Code scanning / lintrunner
SPACES/trailing spaces
- uses: actions/checkout@v2 | ||
- run: npm ci | ||
- name: Install licensed | ||
run: | |
Check failure
Code scanning / lintrunner
ACTIONLINT/[shellcheck]
@@ -0,0 +1,175 @@ | |||
name: Test Upload Artifact S3 Action |
Check failure
Code scanning / lintrunner
SPACES/trailing spaces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks plausible but it needs some changes to pass CI
Thank you! working on resolving the CI issues and linting |
f7c800d
to
0e7ef0c
Compare
Hosting the code for seemethere/upload-artifact-s3 locally to encorage more coolaboration and maintainance of this action. This first migration is based on v5.1.0 Issue: pytorch/ci-infra#242 Signed-off-by: Jessica Wagantall <[email protected]>
0e7ef0c
to
e870760
Compare
Hosting the code for seemethere/upload-artifact-s3 locally to encorage more coolaboration and maintainance of this action.
This first migration is based on v5.1.0
Issue: pytorch/ci-infra#242