Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Migrate seemethere/upload-artifact-s3 locally #6158

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jwagantall
Copy link
Contributor

Hosting the code for seemethere/upload-artifact-s3 locally to encorage more coolaboration and maintainance of this action.

This first migration is based on v5.1.0

Issue: pytorch/ci-infra#242

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 10, 2025
Copy link

vercel bot commented Jan 10, 2025

@jwagantall is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@malfet malfet self-requested a review January 13, 2025 20:08
@malfet
Copy link
Contributor

malfet commented Jan 13, 2025

Changes looks good to me in principle, but we should put some automation into building the actions and testing them, if they are part of test-infra on a personal repo

@jwagantall jwagantall force-pushed the migrate-upload branch 2 times, most recently from f834a73 to f7c800d Compare January 14, 2025 00:34
@@ -0,0 +1,273 @@
# Upload-Artifact v2

Check failure

Code scanning / lintrunner

TABS/saw some tabs

This line has tabs; please replace them with spaces.
@@ -0,0 +1,273 @@
# Upload-Artifact v2

Check failure

Code scanning / lintrunner

SPACES/trailing spaces

This line has trailing spaces; please remove them.
- uses: actions/checkout@v2
- run: npm ci
- name: Install licensed
run: |

Check failure

Code scanning / lintrunner

ACTIONLINT/[shellcheck]

shellcheck reported issue in this script: SC2086:info:1:4: Double quote to prevent globbing and word splitting
@@ -0,0 +1,175 @@
name: Test Upload Artifact S3 Action

Check failure

Code scanning / lintrunner

SPACES/trailing spaces

This line has trailing spaces; please remove them.
Copy link
Contributor

@ZainRizvi ZainRizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks plausible but it needs some changes to pass CI

@jwagantall
Copy link
Contributor Author

Thank you! working on resolving the CI issues and linting

Hosting the code for seemethere/upload-artifact-s3 locally
to encorage more coolaboration and maintainance of this action.

This first migration is based on v5.1.0

Issue: pytorch/ci-infra#242

Signed-off-by: Jessica Wagantall <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants