Stream subprocess stdout #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
H-Huang
added a commit
that referenced
this pull request
Jan 9, 2025
ghstack-source-id: c7e14e5ed4b3fcf735245bc9f2aeec0fdd505dd1 Pull Request resolved: #783
facebook-github-bot
added
the
CLA Signed
c-p-i-o
approved these changes
Jan 9, 2025
H-Huang
added a commit
that referenced
this pull request
Jan 10, 2025
ghstack-source-id: c7e14e5ed4b3fcf735245bc9f2aeec0fdd505dd1 Pull Request resolved: #783
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
The integration tests do not output to terminal unless the process exits, which is a problem I hit when I had a hanging test and there was no output.
Due to setting
stdout=subprocess.PIPE, this captures the standard output of the subprocess. The output is only printed after the process exits. If we dont set stdoutstdout=None, then standard output is not captured; it is inherited from the parent process which is just the terminal and prints out normally.