Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Quentin McGaw <[email protected]>
  • Loading branch information
francesco086 and qdm12 authored Jan 11, 2025
1 parent 4ab47f7 commit d21fd33
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions internal/provider/providers/scaleway/provider.go
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,7 @@ func validateSettings(domain, secretKey string) (err error) {
return fmt.Errorf("%w: %w", errors.ErrDomainNotValid, err)
}

switch {
case secretKey == "":
if secretKey == "" {
return fmt.Errorf("%w", errors.ErrSecretKeyNotSet)
}

Expand Down Expand Up @@ -114,7 +113,7 @@ func (p *Provider) HTML() models.HTMLRow {
}

// Update updates the DNS record for the domain using Scaleway's API.
// See: https://www.scaleway.com/en/developers/api/domains-and-dns/#path-records-update-records-within-a-dns-zone
// See https://www.scaleway.com/en/developers/api/domains-and-dns/#path-records-update-records-within-a-dns-zone
func (p *Provider) Update(ctx context.Context, client *http.Client, ip netip.Addr) (newIP netip.Addr, err error) {
u := url.URL{
Scheme: "https",
Expand Down

0 comments on commit d21fd33

Please sign in to comment.