-
-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add myaddr dynamic dns provider #885
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR 🎖️ 💯 !
A few comments of things to change here and there, but before jumping in this: would you mind creating another separate pull request for the public ip feature, since it should be a separate commit/PR really. Thank you 🙏 👍
Thank you for the quick review :) I believe I've addressed all your comments and made the code more consistent with the project. I've reverted the public IP provider addition for now and will open a separate PR for that. I understand your want for providing the |
Awesome 💯
Perfect 🥇
Eh it's a bit on the user if he/she sets a key not matching the domain. We can do foolproof checks as much as possible, but this seems like a bit too much at the cost of over-complicating it 😄 The API will probably just say the key is wrong anyway. I did however add a little check to prevent multiple domains to be defined in a myaddr settings block since one key is for one domain (and its subdomains), so there would be no point handling it as different entries/updates in parallel, except getting banned for sending too many update requests 😄 Merging this !! |
Adds new dynamic dns provider: https://myaddr.tools
Partially fixes #728 (additional PR for public IP provider to come)
Cheers!