Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debian workflow #1513

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

lovelxc
Copy link

@lovelxc lovelxc commented Nov 15, 2024

Add linux(debian) for workflow

Checklist

Which kind of PR do you create?

  • This PR only contains minor fixes.
  • This PR contains major feature update.
  • This PR introduces a new function/api for Qiling Framework.

Coding convention?

  • The new code conforms to Qiling Framework naming convention.
  • The imports are arranged properly.
  • Essential comments are added.
  • The reference of the new code is pointed out.

Extra tests?

  • No extra tests are needed for this PR.
  • I have added enough tests for this PR.
  • Tests will be added after some discussion and review.

Changelog?

  • This PR doesn't need to update Changelog.
  • Changelog will be updated after some proper review.
  • Changelog has been updated in my PR.

Target branch?

  • The target branch is dev branch.

One last thing


Add linux(debian) for workflow
@wtdcode
Copy link
Member

wtdcode commented Nov 16, 2024

Sorry no offence. This looks like AI generated?

modify some description
@lovelxc
Copy link
Author

lovelxc commented Nov 16, 2024

Sorry no offence. This looks like AI generated?

Yes, but I don't know why some of my modifications weren't written into the build-ci.yml. I intended to finish the build test in my personal branch, but it seems that Qiling hasn't granted the permission for 'Actions' on fork.

@xwings
Copy link
Member

xwings commented Dec 17, 2024

Hi,

Looks good, but just not too sure why do we need another distro and both of them are from the same root.

Any specific reason?

@lovelxc
Copy link
Author

lovelxc commented Dec 20, 2024

Hi,

Looks good, but just not too sure why do we need another distro and both of them are from the same root.

Any specific reason?

  1. The default Python versions of the Debian system and the Ubuntu system are different. With Debian, tests can be conducted under different Python environments. (It's also possible to use virtual environments, but it seems that this wasn't done in the build.yml).

  2. Personally, I think that most people are using the Debian system as a server system, so maybe it's necessary to conduct tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants